mark internal inplace_iteration traits as hidden #85374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Looks good, thanks! Could you confirm that impls are also hidden from docs when the trait has |
|
I have checked |
This comment has been minimized.
This comment has been minimized.
|
r+ as far as I’m concerned, but the link checker is complaining |
the8472
force-pushed
the
hide-internal-traits
branch
from
335d0b2 to
1c6becc
Compare
|
Looks like |
the8472
force-pushed
the
hide-internal-traits
branch
from
1c6becc to
39e492a
Compare
|
This sounds like a rustdoc bug worth filing |
|
@bors r+ |
|
📌 Commit 39e492a has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 39e492a with merge 8c12016f3d06e5156fd55e137ea7bb0dec04131b... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry rollup |
bors
added
S-waiting-on-bors
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 17, 2021
…onSapin mark internal inplace_iteration traits as hidden resolves rust-lang#85373 r? `@SimonSapin`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 17, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#85087 (`eval_fn_call`: check the ABI of `body.source`) - rust-lang#85302 (Expand WASI abbreviation in docs) - rust-lang#85355 (More tests for issue-85255) - rust-lang#85367 (Fix invalid input:disabled CSS selector) - rust-lang#85374 (mark internal inplace_iteration traits as hidden) - rust-lang#85408 (remove size field from Allocation) - rust-lang#85409 (Simplify `cfg(any(unix, target_os="redox"))` in example to just `cfg(unix)`) - rust-lang#85412 (remove some functions that were only used by Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #85373
r? @SimonSapin