Skip to content

Simplify cfg(any(unix, target_os="redox")) in example to just cfg(unix) #85409

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 17, 2021

Conversation

CDirkx
Copy link
Contributor

@CDirkx CDirkx commented May 17, 2021

Update example for OsString that handled redox seperately from unix: Redox has been completely integrated under target_family="unix", so cfg(unix) implies target_os="redox"

os_family: Some("unix".to_string()),

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2021
@nagisa
Copy link
Member

nagisa commented May 17, 2021

@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented May 17, 2021

📌 Commit 3836427 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2021
@nagisa nagisa assigned nagisa and unassigned Mark-Simulacrum May 17, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#85087 (`eval_fn_call`: check the ABI of `body.source`)
 - rust-lang#85302 (Expand WASI abbreviation in docs)
 - rust-lang#85355 (More tests for issue-85255)
 - rust-lang#85367 (Fix invalid input:disabled CSS selector)
 - rust-lang#85374 (mark internal inplace_iteration traits as hidden)
 - rust-lang#85408 (remove size field from Allocation)
 - rust-lang#85409 (Simplify `cfg(any(unix, target_os="redox"))` in example to just `cfg(unix)`)
 - rust-lang#85412 (remove some functions that were only used by Miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 360db9c into rust-lang:master May 17, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 17, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants