Mutate command args #87420

cehteh · 2021-07-24T01:48:11Z

Finished implementation, the 'windows' bits are untested by me, i hope they pass the CI. Otherwise, awaiting comments.

rust-highfive · 2021-07-24T01:48:13Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

Mark-Simulacrum · 2021-08-01T17:53:53Z

r? @joshtriplett - I feel like I saw some T-libs discussion of these APIs recently.

FWIW it'd be ideal to integrate more context into the PR description (presuming I'm recalling correctly that this context exists).

cehteh · 2021-08-01T19:19:23Z

r? @joshtriplett - I feel like I saw some T-libs discussion of these APIs recently.

FWIW it'd be ideal to integrate more context into the PR description (presuming I'm recalling correctly that this context exists).

I didn't know under what circumstances github makes automatic links/references. Usually I made this explicit, but just forgotten to do on the PR request itself.

First discussion is on: https://internals.rust-lang.org/t/lack-of-api-mutating-args-at-std-command/14908
For the implementation I opened a issue: #87379

bors · 2021-10-01T06:34:59Z

☔ The latest upstream changes (presumably #89414) made this pull request unmergeable. Please resolve the merge conflicts.

joshtriplett · 2021-10-04T04:05:26Z

I think I remember this being discussed elsewhere, but I don't remember the outcome:

I think arg_set(0, ...) should work on UNIX, and act equivalent to calling arg0, rather than asserting.
I don't think we should add the args_new helper; I think .args_clear().args(...) seems clearer.

JohnCSimon · 2021-10-24T03:41:43Z

Ping from triage:
@cehteh can you please address the comments and set S-waiting-on-review when you're done? Thank you.

cehteh · 2021-10-24T07:25:55Z

I think I remember this being discussed elsewhere, but I don't remember the outcome:

I think arg_set(0, ...) should work on UNIX, and act equivalent to calling arg0, rather than asserting.

As discussed in https://internals.rust-lang.org/t/lack-of-api-mutating-args-at-std-command/14908/6
I came to the conclusion it is better not to touch argv[0] here, because

none of the other .args*() API's can change it either
.clear() has to preserve it
it is 'slightly' special in semantics
changing it is not portable to all operating systems

I could imagine a .set_program_name() member function. This would be made more portable to OS'es which support this in other ways. Question is if it should go into this PR or being another ticket/PR since that would some more investigation/work how to make it portable and I haven't thought about what to do if such is not supported (rust emulation, conditional API, some Ext trait, runtime error result, ...).

I don't think we should add the args_new helper; I think .args_clear().args(...) seems clearer.

Ok I'll remove that later today. I wasn't sure if its a nice to have or unnecessary.

cehteh · 2021-10-24T15:48:55Z

Ping from triage: @cehteh can you please address the comments and set S-waiting-on-review when you're done? Thank you.

how do i set S-waiting-on-review ?

hkratz · 2021-10-24T15:51:45Z

Like this:
@rustbot label -S-waiting-on-author +S-waiting-on-review

(rustbot documentation)

bors · 2021-10-25T14:55:17Z

☔ The latest upstream changes (presumably #90042) made this pull request unmergeable. Please resolve the merge conflicts.

cehteh · 2021-10-25T15:54:04Z

tidy error: /checkout/src/doc/rustc-dev-guide/ci/date-check/Cargo.toml doesn't have edition = "2021" on a separate line
tidy error: /checkout/src/doc/reference/style-check/Cargo.toml doesn't have edition = "2021" on a separate line

These errors exist in upstream I merged, not being introduced by this PR.

Will try to merge or rebase again when that becomes fixed.

bors · 2021-11-11T02:16:08Z

☔ The latest upstream changes (presumably #90784) made this pull request unmergeable. Please resolve the merge conflicts.

see rust-lang#87379 Only unix implementation yet.

Only unix implementation yet.

We do not want to set argv[0] here. This needs to be asserted at any time. Assertion for the index within range is only a debug_assert becasue its a mere helpful error message, indexing later would assert on out of range access anyway.

This reverts commit 626d0e71b1e82c4804cec1a2bd03c3c53e4368ad. * removes 'args_new()' as requested in rust-lang#87420 (comment) * still disallow argv0 mutation as I explained in rust-lang#87420 (comment)

cehteh · 2021-12-08T08:45:07Z

Had some f*ckup with submodule hashes slipped into the commit. Fixed now, ready to merge.

Dylan-DPC · 2022-02-19T02:28:49Z

@joshtriplett this is ready for review

Dylan-DPC · 2022-05-13T11:16:25Z

r? @rust-lang/libs-api

m-ou-se · 2022-05-16T09:58:38Z

I'm not convinced we should have this at all. Even the existing Command::get_args was quite controversial, since we don't want to provide a full Vec-like interface on Command. If you want to flexibly work with arguments before running the Command, it's probably better to just use a regular Vec before passing it to Command::args().

@rust-lang/libs-api - Does anyone else think we should have this?

Dylan-DPC · 2022-06-02T10:56:49Z

closing this based on the last comment

rust-highfive assigned Mark-Simulacrum Jul 24, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2021

rust-highfive assigned joshtriplett and unassigned Mark-Simulacrum Aug 1, 2021

joelpalmer added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2021

inquisitivecrystal added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 24, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2021

cehteh force-pushed the mutate_command_args branch from f42c400 to 54ca0e2 Compare October 1, 2021 09:35

joshtriplett added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2021

cehteh force-pushed the mutate_command_args branch from 54ca0e2 to f71c15b Compare October 24, 2021 15:19

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2021

This comment has been minimized.

# to view

cehteh force-pushed the mutate_command_args branch from 2178fa4 to a25c983 Compare November 10, 2021 13:04

This comment has been minimized.

# to view

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2021

cehteh added 7 commits December 8, 2021 08:03

implement std::process::Command::args_clear()

a2fbdd3

see rust-lang#87379 Only unix implementation yet.

implement std::process::Command::arg_set()

c420fdc

Only unix implementation yet.

implement std::process::Command::args_new()

6a10a48

FIX: assert >= 1 in process::command::arg_set()

816e4ec

We do not want to set argv[0] here. This needs to be asserted at any time. Assertion for the index within range is only a debug_assert becasue its a mere helpful error message, indexing later would assert on out of range access anyway.

Provide the windows implementation of args_clear() and arg_set()

ca62a97

DOCFIX: arg_set() lacked doc/panics

9d69f08

Revert "implement std::process::Command::args_new()"

45d1780

This reverts commit 626d0e71b1e82c4804cec1a2bd03c3c53e4368ad. * removes 'args_new()' as requested in rust-lang#87420 (comment) * still disallow argv0 mutation as I explained in rust-lang#87420 (comment)

cehteh force-pushed the mutate_command_args branch from a25c983 to 45d1780 Compare December 8, 2021 07:05

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2022

rust-highfive assigned m-ou-se and unassigned joshtriplett May 13, 2022

Dylan-DPC closed this Jun 2, 2022

Dylan-DPC removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2022

cehteh mentioned this pull request Feb 28, 2023

Mutate arguments at std::process::Command #87379

Closed

5 tasks

Mutate command args #87420

Mutate command args #87420

Uh oh!

Conversation

cehteh commented Jul 24, 2021

Uh oh!

rust-highfive commented Jul 24, 2021

Uh oh!

Mark-Simulacrum commented Aug 1, 2021

Uh oh!

cehteh commented Aug 1, 2021

Uh oh!

bors commented Oct 1, 2021

Uh oh!

joshtriplett commented Oct 4, 2021

Uh oh!

JohnCSimon commented Oct 24, 2021

Uh oh!

cehteh commented Oct 24, 2021

Uh oh!

cehteh commented Oct 24, 2021

Uh oh!

hkratz commented Oct 24, 2021

Uh oh!

bors commented Oct 25, 2021

Uh oh!

This comment has been minimized.

cehteh commented Oct 25, 2021

Uh oh!

This comment has been minimized.

bors commented Nov 11, 2021

Uh oh!

cehteh commented Dec 8, 2021

Uh oh!

Dylan-DPC commented Feb 19, 2022

Uh oh!

Dylan-DPC commented May 13, 2022

Uh oh!

m-ou-se commented May 16, 2022

Uh oh!

Dylan-DPC commented Jun 2, 2022

Uh oh!

Uh oh!