Skip to content

Bump bootstrap compiler to 1.57 #90042

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2021
Merged

Bump bootstrap compiler to 1.57 #90042

merged 4 commits into from
Oct 25, 2021

Conversation

pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented Oct 19, 2021 •
edited by Mark-Simulacrum
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2021
@rust-log-analyzer

This comment has been minimized.

# to view
@Mark-Simulacrum
Copy link
Member

r=me with CI fixed, but I'm not sure what's up with that assert failing...

@tmandry
Copy link
Member

tmandry commented Oct 19, 2021

Should this wait on the backport of #90038?

@Mark-Simulacrum
Copy link
Member

Probably not critical in some sense -- we still end up with potentially miscompiled compilers due to staging -- but it may also fix CI here? Not clear.

@ehuss ehuss mentioned this pull request Oct 20, 2021
Merged
@bors
Copy link
Collaborator

bors commented Oct 20, 2021

☔ The latest upstream changes (presumably #90067) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

# to view
This was referenced Oct 22, 2021
Closed
Closed
@cuviper cuviper mentioned this pull request Oct 22, 2021
Closed
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Oct 23, 2021
Closed
@rust-log-analyzer

This comment has been minimized.

# to view
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

Included patch to workaround #90153 and rolled in #90185.

@bors
Copy link
Collaborator

bors commented Oct 23, 2021

📌 Commit dbd77c05ed053c222f7aed1e733a462128909132 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2021
@jyn514 jyn514 mentioned this pull request Oct 23, 2021
Merged
@cuviper
Copy link
Member

cuviper commented Oct 23, 2021

FYI, the bump to min LLVM 12 is now approved in #90175.

@bors
Copy link
Collaborator

bors commented Oct 24, 2021

☔ The latest upstream changes (presumably #90175) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 24, 2021
@Mark-Simulacrum
Copy link
Member

@bors retry -- hopefully the markdown-css error is spurious and caused by the rustc-rayon-core overflow check failure

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2021
@bors
Copy link
Collaborator

bors commented Oct 24, 2021

⌛ Testing commit abd3fe3 with merge 448d8243a1b0572c97a6ae68c3a2170541fb9ad4...

@bors
Copy link
Collaborator

bors commented Oct 24, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 24, 2021
@Mark-Simulacrum
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Oct 25, 2021

⌛ Testing commit abd3fe3 with merge 7621e0fad94a3e8ce9a9eb28f0a0a2d3709a12a9...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
.......   (48/48)


search-tab-selection-if-current-is-empty... FAILED
[ERROR] (line 4) TimeoutError: waiting for selector "#titles" failed: timeout 30000ms exceeded: for command `// Waiting for the search results to appear...
wait-for: "#titles"`



command did not execute successfully: "/node-v14.4.0-linux-x64/bin/node" "/checkout/src/tools/rustdoc-gui/tester.js" "--jobs" "16" "--doc-folder" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc" "--tests-folder" "/checkout/src/test/rustdoc-gui"


Build completed unsuccessfully in 0:00:46

@bors
Copy link
Collaborator

bors commented Oct 25, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 25, 2021
@matthiaskrgr
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2021
@bors
Copy link
Collaborator

bors commented Oct 25, 2021

⌛ Testing commit abd3fe3 with merge 235d985...

@bors
Copy link
Collaborator

bors commented Oct 25, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 235d985 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 25, 2021
@bors bors merged commit 235d985 into rust-lang:master Oct 25, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 25, 2021
This was referenced Oct 25, 2021
Closed
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (235d985): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@ssomers ssomers mentioned this pull request Nov 27, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.

rustc_mir_dataflow tests fail with debug-assertions enabled