Refactor named_asm_labels to a HIR lint
#88196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @Amanieu |
nbdd0121
reviewed
Aug 20, 2021
| @@ -19,20 +19,20 @@ use crate::token; | |||
| use rustc_span::symbol::{Ident, Symbol}; | |||
| use rustc_span::Span; | |||
|
|
|||
| #[derive(Copy, Clone, PartialEq)] | |||
| #[derive(Copy, Clone, Debug, PartialEq)] | |||
There was a problem hiding this comment.
Are these Debugs necessary?
There was a problem hiding this comment.
No they are not, but I was under the impression that things that can be #[derive(Debug)] should be, for ease of use for other people. I had to add the derive to see some of the stuff that was passed to the ast early lint when I had an early pass version.
Amanieu
reviewed
Aug 20, 2021
asquared31415
force-pushed
the
named-asm-labels-refactor
branch
from
f94626e to
9f558ff
Compare
|
@bors r+ |
|
📌 Commit 9f558ff79fc4ab104d43b5a42fa26156489a33fa has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #87739) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
asquared31415
force-pushed
the
named-asm-labels-refactor
branch
from
9f558ff to
0b81c2e
Compare
|
@bors r+ |
|
📌 Commit 0b81c2e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 25, 2021
…eulArtichaut Rollup of 16 pull requests Successful merges: - rust-lang#87944 (add Cell::as_array_of_cells, similar to Cell::as_slice_of_cells) - rust-lang#88156 (Adjust / fix documentation of `Arc::make_mut`) - rust-lang#88157 (bootstrap.py: recognize riscv64 when auto-detect) - rust-lang#88196 (Refactor `named_asm_labels` to a HIR lint) - rust-lang#88218 (Remove `Session.trait_methods_not_found`) - rust-lang#88223 (Remove the `TryV2` alias) - rust-lang#88226 (Fix typo “a Rc” → “an Rc” (and a few more)) - rust-lang#88267 (2229: Update signature for truncate function) - rust-lang#88273 (Fix references to `ControlFlow` in docs) - rust-lang#88277 (Update books) - rust-lang#88291 (Add SAFETY comments to core::slice::sort::partition_in_blocks) - rust-lang#88293 (Fix grammar in alloc test) - rust-lang#88298 (Errorkind reorder) - rust-lang#88299 (Stabilise BufWriter::into_parts) - rust-lang#88314 (Add type of a let tait test) - rust-lang#88325 (Add mutable-noalias to the release notes for 1.54) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #88169, the
named_asm_labelslint could be moved to a HIR lint. That allows future lints or custom plugins or clippy lints to more easily access theasm!macro's data and create better error messages with the lints.