-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix references to ControlFlow
in docs
#88273
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
I don't see how that relates to |
Returning (No I didn't try it. I made an assumption) |
It requires a |
Ah, right. Sometimes I miss the obvious. I'll revert that bit of the commit, leaving the fix to the path elsewhere. |
da61710
to
bc33861
Compare
Iterator
docs to acknowledge ControlFlow
ControlFlow
in docs
@jhpratt is there a reason you picked me particularly to review? I'm not on the libs team. |
That said, this looks good to me :) @bors r+ rollup |
📌 Commit bc33861 has been approved by |
I thought that you've done stuff with docs in the past. Not that the reviewer really matters here admittedly. |
I mostly work on rustdoc; different sort of docs :P |
I had the right idea 😂 Good to know for the future. |
…eulArtichaut Rollup of 16 pull requests Successful merges: - rust-lang#87944 (add Cell::as_array_of_cells, similar to Cell::as_slice_of_cells) - rust-lang#88156 (Adjust / fix documentation of `Arc::make_mut`) - rust-lang#88157 (bootstrap.py: recognize riscv64 when auto-detect) - rust-lang#88196 (Refactor `named_asm_labels` to a HIR lint) - rust-lang#88218 (Remove `Session.trait_methods_not_found`) - rust-lang#88223 (Remove the `TryV2` alias) - rust-lang#88226 (Fix typo “a Rc” → “an Rc” (and a few more)) - rust-lang#88267 (2229: Update signature for truncate function) - rust-lang#88273 (Fix references to `ControlFlow` in docs) - rust-lang#88277 (Update books) - rust-lang#88291 (Add SAFETY comments to core::slice::sort::partition_in_blocks) - rust-lang#88293 (Fix grammar in alloc test) - rust-lang#88298 (Errorkind reorder) - rust-lang#88299 (Stabilise BufWriter::into_parts) - rust-lang#88314 (Add type of a let tait test) - rust-lang#88325 (Add mutable-noalias to the release notes for 1.54) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
The
Iterator::for_each
method previously stated that it was not possible to usebreak
andcontinue
in it — this has been updated to acknowledge the stabilization ofControlFlow
. Additionally,ControlFlow
was referred to ascrate::ops::ControlFlow
which is not the correct path for an end user.r? @jyn514