Skip to content

Make UnsafeCell::get_mut const #88722

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

WaffleLapkin
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2021
@the8472 the8472 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 8, 2021
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Can you make a tracking issue or tack this on to an existing appropriate one?

@WaffleLapkin
Copy link
Member Author

@dtolnay done

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Sep 12, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 12, 2021

📌 Commit 2c30162 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2021
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 12, 2021
…mut, r=dtolnay

Make `UnsafeCell::get_mut` const
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 12, 2021
…mut, r=dtolnay

Make `UnsafeCell::get_mut` const
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 13, 2021
…mut, r=dtolnay

Make `UnsafeCell::get_mut` const
This was referenced Sep 13, 2021
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 14, 2021
…mut, r=dtolnay

Make `UnsafeCell::get_mut` const
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 14, 2021
…mut, r=dtolnay

Make `UnsafeCell::get_mut` const
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 14, 2021
…laumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#88033 (Add links for primitives in "jump to definition" feature)
 - rust-lang#88722 (Make `UnsafeCell::get_mut` const)
 - rust-lang#88851 (Fix duplicate bounds for const_trait_impl)
 - rust-lang#88859 (interpreter PointerArithmetic: use new Size helper methods)
 - rust-lang#88885 (Fix jump def background)
 - rust-lang#88894 (Improve error message for missing trait in trait impl)
 - rust-lang#88896 (Reduce possibility of flaky tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5eb7783 into rust-lang:master Sep 14, 2021
@WaffleLapkin WaffleLapkin deleted the unsafe_cell_const_get_mut branch September 18, 2021 15:54
@cuviper cuviper added this to the 1.57.0 milestone Nov 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants