Rollup of 7 pull requests #88914
Merged
Rollup of 7 pull requests #88914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add test for jump-to-def links background color
…e, r=jyn514 Add links for primitives in "jump to definition" feature Follow-up of rust-lang#84176. I created a function `primitive_from_str` which is code that was originally in `collect_intra_doc_links::resolve_primitive` to prevent code duplication. I also created the `primitive_link_url` function which is somewhat similar to `primitive_link` but too much different to merge both of them. r? ``@jyn514``
…mut, r=dtolnay Make `UnsafeCell::get_mut` const
Fix duplicate bounds for const_trait_impl Fixes rust-lang#88383. Compare the constness of the candidates before winnowing and removing a `~const` `BoundCandidate`.
interpreter PointerArithmetic: use new Size helper methods
…und, r=camelid Fix jump def background Fixes rust-lang#88870. I somehow badly wrote the color in rust-lang#88111. r? ``@camelid``
Improve error message for missing trait in trait impl Fixes rust-lang#88818. For the following example: ```rust struct S { } impl for S { } ``` the current output is: ``` error: missing trait in a trait impl --> t1.rs:2:5 | 2 | impl for S { } | ^ ``` With my changes, I get: ``` error: missing trait in a trait impl --> t1.rs:2:5 | 2 | impl for S { } | ^ | help: add a trait here | 2 | impl Trait for S { } | +++++ help: for an inherent impl, drop this `for` | 2 - impl for S { } 2 + impl S { } | ```
Reduce possibility of flaky tests As asked in rust-lang#88885. r? ``@camelid``
|
@bors: r+ p=7 rollup=never |
|
📌 Commit fb673bf has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit fb673bf with merge c2b6f509ddefefe4e5e24c429a858caaca4bffe7... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit fb673bf with merge aa6c2e7c7beac1453f9d69afdcea9f206c231699... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit fb673bf with merge 881294142018d533cd14d1961dc7d8f5057c3e47... |
|
@bors: retry |
|
⌛ Testing commit fb673bf with merge 0ebb2287de7cbae5d644ffa976e6ec5b269fda9c... |
|
@bors: retry |
|
@rust-lang/infra Is the CI dead? |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (ec9a1bd): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
UnsafeCell::get_mutconst #88722 (MakeUnsafeCell::get_mutconst)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup