Rollup of 8 pull requests #90000
Merged
Rollup of 8 pull requests #90000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the verbosity settings are:
- 2: RUSTC-SHIM envvars get spammed on every invocation, O(30) lines
cargo is passed -v which outputs CLI invocations, O(5) lines
- 3: cargo is passed -vv which outputs build script output, O(0-10) lines
This commit changes it to:
- 1: cargo is passed -v, O(5) lines
- 2: cargo is passed -vv, O(10) lines
- 3: RUSTC-SHIM envvars get spammed, O(30) lines
The equivalent for `Symbol`s was renamed some time ago (`kw::Invalid` -> `kw::Empty`), and it makes sense to do the same thing for `Ident`s.
rust-lang/backtrace-rs#446 allows binaries built with Nix on macOS to be symbolized.
bootstrap: tweak verbosity settings
Currently the verbosity settings are:
- 2: RUSTC-SHIM envvars get spammed on every invocation, O(30) lines
cargo is passed -v which outputs CLI invocations, O(5) lines
- 3: cargo is passed -vv which outputs build script output, O(0-10) lines
This commit changes it to:
- 1: cargo is passed -v, O(5) lines
- 2: cargo is passed -vv, O(10) lines
- 3: RUSTC-SHIM envvars get spammed, O(30) lines
…-mut, r=petrochenkov Fix ICE with `let...else` and `ref mut` Fixes rust-lang#89960, opened for review. I'm not satisfied with the current diagnostics, any ideas?
Nicer error message if the user attempts to do let...else if Gives a nice "conditional `else if` is not supported for `let...else`" error when encountering a `let...else if` pattern, as suggested in the [let...else tracking issue](rust-lang#87335 (comment)).
…c, r=GuillaumeGomez Check implementing type for `#[doc(hidden)]` Closes rust-lang#85526.
rustdoc: Add static size assertion for `clean::Type` r? `@jyn514`
rustc_span: `Ident::invalid` -> `Ident::empty` The equivalent for `Symbol`s was renamed some time ago (`kw::Invalid` -> `kw::Empty`), and it makes sense to do the same thing for `Ident`s as well.
Remove dead code from `compiletest::json` Currently getting a dead code warning on master. Might make sense to remove.
…ulacrum Bump backtrace rust-lang/backtrace-rs#446 allows binaries built with Nix on macOS to be symbolized.
|
@bors r+ p=8 rollup=never |
|
📌 Commit 2724b00 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (5dab47d): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
let...elseandref mut#89965 (Fix ICE withlet...elseandref mut)#[doc(hidden)]#89987 (Check implementing type for#[doc(hidden)])clean::Type#89989 (rustdoc: Add static size assertion forclean::Type)Ident::invalid->Ident::empty#89990 (rustc_span:Ident::invalid->Ident::empty)compiletest::json#89993 (Remove dead code fromcompiletest::json)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup