Skip to content

Document how recursion is handled for ty::Ty #90538

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 4, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Nov 3, 2021

@camelid camelid added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 3, 2021
@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 3, 2021
@camelid camelid added the A-type-system Area: Type system label Nov 3, 2021
@camelid
Copy link
Member Author

camelid commented Nov 3, 2021

r? @estebank

@camelid
Copy link
Member Author

camelid commented Dec 1, 2021

r? rust-lang/compiler

@rust-highfive rust-highfive assigned oli-obk and unassigned estebank Dec 1, 2021
@estebank
Copy link
Contributor

estebank commented Dec 2, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 2, 2021

📌 Commit 2c1cf5a has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2021
@jackh726
Copy link
Member

jackh726 commented Dec 2, 2021

@bors rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 2, 2021
Document how recursion is handled for `ty::Ty`

Based on this forum discussion:
https://internals.rust-lang.org/t/recursive-type-representation-in-rustc/15235/4

cc `@estebank`
@matthiaskrgr
Copy link
Member

@bors r-
failed in #91458 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 2, 2021
@estebank
Copy link
Contributor

estebank commented Dec 2, 2021

@camelid r=me after fixing the linked type 😅

@camelid
Copy link
Member Author

camelid commented Dec 3, 2021

@bors r=estebank

@bors
Copy link
Collaborator

bors commented Dec 3, 2021

📌 Commit 9931782 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2021
@camelid camelid assigned estebank and unassigned oli-obk Dec 3, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 4, 2021
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#90538 (Document how recursion is handled for `ty::Ty`)
 - rust-lang#90851 (Add unchecked downcast methods)
 - rust-lang#91209 (Implement ``@snapshot`` check for htmldocck)
 - rust-lang#91385 (Suggest the `pat_param` specifier before `|` on 2021 edition )
 - rust-lang#91478 (Remove incorrect newline from float cast suggestion)
 - rust-lang#91481 (Use let_else in some more places in rustc_lint)
 - rust-lang#91488 (Fix ICE when `yield`ing in function returning `impl Trait`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f99cd40 into rust-lang:master Dec 4, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 4, 2021
@camelid camelid deleted the doc-recur-ty branch December 4, 2021 06:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-type-system Area: Type system S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants