Skip to content

Remove incorrect newline from float cast suggestion #91478

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2021
Merged

Remove incorrect newline from float cast suggestion #91478

merged 1 commit into from
Dec 4, 2021

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Dec 3, 2021

No description provided.

@rust-highfive
Copy link
Contributor

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2021
@camelid camelid added A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 3, 2021
@camelid
Copy link
Member

camelid commented Dec 3, 2021

r? @camelid

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 3, 2021

📌 Commit 5b5df0f has been approved by camelid

@rust-highfive rust-highfive assigned camelid and unassigned wesleywiser Dec 3, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 4, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 4, 2021
@bors
Auto merge of rust-lang#91505 - matthiaskrgr:rollup-orxgsxo, r=matthi…
f581572 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#90538 (Document how recursion is handled for `ty::Ty`)
 - rust-lang#90851 (Add unchecked downcast methods)
 - rust-lang#91209 (Implement ``@snapshot`` check for htmldocck)
 - rust-lang#91385 (Suggest the `pat_param` specifier before `|` on 2021 edition )
 - rust-lang#91478 (Remove incorrect newline from float cast suggestion)
 - rust-lang#91481 (Use let_else in some more places in rustc_lint)
 - rust-lang#91488 (Fix ICE when `yield`ing in function returning `impl Trait`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f9587b6 into rust-lang:master Dec 4, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 4, 2021
@estebank estebank deleted the fix-newline-in-cast-suggestion branch November 9, 2023 05:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@camelid camelid camelid approved these changes

Assignees

@camelid camelid

Labels
A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
6 participants
@estebank @rust-highfive @camelid @bors @wesleywiser @rustbot