Skip to content

Run reveal_all on MIR when inlining is activated. #90649

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Nov 6, 2021

Fix logic error in #85254 which prevented the pass from running when needed.
Fixes #78442
r? @lcnr

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2021
@lcnr
Copy link
Contributor

lcnr commented Nov 6, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 6, 2021

📌 Commit a3776d9 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2021
Run reveal_all on MIR when inlining is activated.

Fix logic error in rust-lang#85254 which prevented the pass from running when needed.
Fixes rust-lang#78442
r? `@lcnr`
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 6, 2021
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#90487 (Add a chapter on reading Rustdoc output)
 - rust-lang#90508 (Apply adjustments for field expression even if inaccessible)
 - rust-lang#90627 (Suggest dereference of `Box` when inner type is expected)
 - rust-lang#90642 (use matches!() macro in more places)
 - rust-lang#90646 (type error go brrrrrrrr)
 - rust-lang#90649 (Run reveal_all on MIR when inlining is activated.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ec471de into rust-lang:master Nov 7, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 7, 2021
@cjgillot cjgillot deleted the reveal-all-2 branch November 26, 2021 22:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: broken mir with -Zinline-mir issue-50865-private-impl-trait/auxiliary/lib.rs
5 participants