Rollup of 7 pull requests #92003
Merged
Rollup of 7 pull requests #92003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const_manually_drop was stabilized in 1.32 as mentioned in https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1320-2019-01-17
These are currently documented at https://rustc-dev-guide.rust-lang.org/rustdoc-internals.html#hot-potato but can easily go out of date. We'd like to document them in place and link to https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc/passes/index.html
…rochenkov Warn when a `#[test]`-like built-in attribute macro is present multiple times. Fixes rust-lang#90979.
…rop-since, r=kennytm Fix since attribute for const_manually_drop feature const_manually_drop was stabilized in 1.32 as mentioned in https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1320-2019-01-17
…wiser Remove `in_band_lifetimes` from `rustc_borrowck` See rust-lang#91867 for more information.
…riplett Add `io::Error::other` This PR adds a small utility constructor, `io::Error::other`, a shorthand for `io::Error::new(io::ErrorKind::Other, err)`, something I find myself writing often. For some concrete stats, a quick search on [grep.app](https://grep.app) shows that more than half of the uses of `io::Error::new` use `ErrorKind::Other`: ``` Error::new\((?:std::)?(?:io::)?ErrorKind:: => 3,898 results Error::new\((?:std::)?(?:io::)?ErrorKind::Other => 2,186 results ```
Pull in libdevstat on FreeBSD Similar to rust-lang#90495, spotted in rust-lang#91909.
Add module documentation for rustdoc passes These are currently documented at https://rustc-dev-guide.rust-lang.org/rustdoc-internals.html#hot-potato but can easily go out of date. We'd like to document them in place and link to https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc/passes/index.html [Discussed on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/moving.20pass.20docs/near/265058351). r? `@camelid`
Fix default_method_body_is_const when used across crates r? `@oli-obk` unblocks rust-lang#91439.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=7 |
|
📌 Commit a97384d has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit a97384d with merge 52eebf5286e11defcd938471afa45d0e733fba76... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry dist-x86_64-apple-alt did not start it seems |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (23c2723): comparison url. Summary: This change led to very large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[test]-like built-in attribute macro is present multiple times. #91172 (Warn when a#[test]-like built-in attribute macro is present multiple times.)in_band_lifetimesfromrustc_borrowck#91879 (Removein_band_lifetimesfromrustc_borrowck)io::Error::other#91947 (Addio::Error::other)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup