Improve suggestion to change struct field to &mut #91516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
apiraino
added
the
T-compiler
|
☔ The latest upstream changes (presumably #92003) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me after rebasing |
rukai
force-pushed
the
improve_mut_addition_help
branch
from
e535856 to
97bf7b9
Compare
|
r=estebank |
estebank
approved these changes
Dec 17, 2021
| format!("&{}mut {}", lifetime_snippet, &*type_snippet,), | ||
| )); | ||
| return Some( | ||
| lifetime.span.with_hi(lifetime.span.hi() + BytePos(1)).shrink_to_hi(), |
There was a problem hiding this comment.
Suggested change
| lifetime.span.with_hi(lifetime.span.hi() + BytePos(1)).shrink_to_hi(), | |
| lifetime.span.between(ty.span), |
| lifetime, | ||
| hir::MutTy { mutbl: hir::Mutability::Not, ref ty }, | ||
| ) = field.ty.kind | ||
| if let hir::TyKind::Rptr(lifetime, hir::MutTy { mutbl: hir::Mutability::Not, .. }) = |
There was a problem hiding this comment.
Suggested change
| if let hir::TyKind::Rptr(lifetime, hir::MutTy { mutbl: hir::Mutability::Not, .. }) = | |
| if let hir::TyKind::Rptr(lifetime, hir::MutTy { mutbl: hir::Mutability::Not, ty }) = |
|
Ended up having to change some other things to get it working like that. Does this look good? Also I'd like to know what the |
rukai
force-pushed
the
improve_mut_addition_help
branch
from
f444260 to
e573075
Compare
|
@bors r+ rollup
you can do |
|
📌 Commit e573075 has been approved by |
bors
added
S-waiting-on-bors
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit e573075 has been approved by `estebank`` |
|
@bors r=estebank |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit e573075 has been approved by |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 18, 2021
…estebank Improve suggestion to change struct field to &mut r? `@estebank` Now displays a proper underline style suggestion instead of including the code change inline with the message.
This was referenced Dec 18, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 18, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91439 (Mark defaulted `PartialEq`/`PartialOrd` methods as const) - rust-lang#91516 (Improve suggestion to change struct field to &mut) - rust-lang#91896 (Remove `in_band_lifetimes` for `rustc_passes`) - rust-lang#91909 (:arrow_up: rust-analyzer) - rust-lang#91922 (Remove `in_band_lifetimes` from `rustc_mir_dataflow`) - rust-lang#92025 (Revert "socket ancillary data implementation for dragonflybsd.") - rust-lang#92030 (Update stdlib to the 2021 edition) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @estebank
Now displays a proper underline style suggestion instead of including the code change inline with the message.