Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rollup of 7 pull requests #92062

Merged
merged 17 commits into from
Dec 18, 2021
Merged

Rollup of 7 pull requests #92062

merged 17 commits into from
Dec 18, 2021

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

lnicola and others added 17 commits December 14, 2021 17:03
@lnicola
⬆️ rust-analyzer
c771970
@pitaj
Remove in_band_lifetimes for rustc_passes
c4bafaf
@LegionMammal978
Remove in_band_lifetimes from rustc_mir_dataflow
fed881a 
See rust-lang#91867 for more information.
@devnexen
Revert "socket ancillary data implementation for dragonflybsd."
78a3078
@rukai
Improve suggestion to change struct field to &mut
97bf7b9
@ecstatic-morse
Mark defaulted PartialEq/PartialOrd methods as const
9c83b56
@ecstatic-morse
Test const impl of cmp traits
1606335
@ecstatic-morse
Disable test on bootstrap compiler
2049287
@rukai
Update stdlib to the 2021 edition
b656384
@rukai
get_mut_span_in_struct_field uses span.between
e573075
@matthiaskrgr
Rollup merge of rust-lang#91439 - ecstatic-morse:const-cmp-trait-defa…
359c88e 
…ult-methods, r=oli-obk

Mark defaulted `PartialEq`/`PartialOrd` methods as const

WIthout it, `const` impls of these traits are unpleasant to write. I think this kind of change is allowed now. although it looks like it might require some Miri tweaks. Let's find out.

r? ```@fee1-dead```
@matthiaskrgr
Rollup merge of rust-lang#91516 - rukai:improve_mut_addition_help, r=…
57d49f1 
…estebank

Improve suggestion to change struct field to &mut

r? ``@estebank``

Now displays a proper underline style suggestion instead of including the code change inline with the message.
@matthiaskrgr
Rollup merge of rust-lang#91896 - pitaj:91867-passes, r=michaelwoerister
eb3cc13 
Remove `in_band_lifetimes` for `rustc_passes`

rust-lang#91867
@matthiaskrgr
Rollup merge of rust-lang#91909 - lnicola:rust-analyzer-2021-12-14, r…
e6b99fa 
…=lnicola

⬆️ rust-analyzer

r? ```@ghost```
@matthiaskrgr
Rollup merge of rust-lang#91922 - LegionMammal978:less-inband-mir_dat…
d2f2f0b 
…aflow, r=nagisa

Remove `in_band_lifetimes` from `rustc_mir_dataflow`

See rust-lang#91867 for more information.
@matthiaskrgr
Rollup merge of rust-lang#92025 - devnexen:revert-91553-anc_data_dfbs…
e69acda 
…d, r=kennytm

Revert "socket ancillary data implementation for dragonflybsd."

Reverts rust-lang#91553
@matthiaskrgr
Rollup merge of rust-lang#92030 - rukai:stdlib2021, r=m-ou-se
efbefb6 
Update stdlib to the 2021 edition

progress towards rust-lang#88638

I couldnt find a way to run the 2018 style panic tests against 2018 so I just deleted them, maybe theres a way to do it that I missed though?
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 18, 2021
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented Dec 18, 2021

📌 Commit efbefb6 has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 18, 2021
@bors
Copy link
Contributor

bors commented Dec 18, 2021

⌛ Testing commit efbefb6 with merge d3f3004...

@bors
Copy link
Contributor

bors commented Dec 18, 2021

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d3f3004 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 18, 2021
@bors bors merged commit d3f3004 into rust-lang:master Dec 18, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 18, 2021
@bors bors mentioned this pull request Dec 18, 2021
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d3f3004): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

  • Large improvement in instruction counts (up to -4.7% on incr-patched: println builds of regression-31157)
  • Small regression in instruction counts (up to 1.0% on full builds of webrender)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Dec 18, 2021
@matthiaskrgr matthiaskrgr deleted the rollup-en3p4sb branch January 2, 2022 22:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
10 participants
@matthiaskrgr @bors @rust-timer @rustbot @lnicola @pitaj @LegionMammal978 @devnexen @rukai @ecstatic-morse