Add try_reserve and try_reserve_exact for OsString #92338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
5 tasks
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Xuanwo <github@xuanwo.io>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Xuanwo <github@xuanwo.io>
dtolnay
requested changes
Dec 28, 2021
dtolnay
added
S-waiting-on-author
Co-authored-by: David Tolnay <dtolnay@gmail.com>
Signed-off-by: Xuanwo <github@xuanwo.io>
|
@dtolnay Thanks for the nice and patient review, I have addressed all comments, PTAL. |
It appears `find_max_slow` comes from the BinaryHeap docs, where the try_reserve example is a slow implementation of find_max. It has no relevance to this code in OsString though.
|
@bors r+ |
|
📌 Commit d29941e has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d29941e with merge 36eb8c7ebc5e5fce4219c6ea512ca9ce462ee1e2... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90383 (Extend check for UnsafeCell in consts to cover unions) - rust-lang#91375 (config.rs: Add support for a per-target default_linker option.) - rust-lang#91480 (rustdoc: use smaller number of colors to distinguish items) - rust-lang#92338 (Add try_reserve and try_reserve_exact for OsString) - rust-lang#92405 (Add a couple needs-asm-support headers to tests) - rust-lang#92435 (Sync rustc_codegen_cranelift) - rust-lang#92440 (Fix mobile toggles position) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
try_reserveandtry_reserve_exactfor OsString.Part of #91789
I will squash the commits after PR is ready to merge.
Signed-off-by: Xuanwo github@xuanwo.io