Skip to content

Fix mobile toggles position #92440

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 1, 2022
Merged

Fix mobile toggles position #92440

merged 2 commits into from
Jan 1, 2022

Conversation

GuillaumeGomez
Copy link
Member

Before:

Screenshot from 2021-12-29 18-53-33

After:

Screenshot from 2021-12-29 18-52-48

r? @jsha

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Dec 30, 2021
@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 30, 2021
@jsha
Copy link
Contributor

jsha commented Dec 30, 2021

@bors r+ rollup

This looks good as a quick fix to a clear problem. It does make me think that the [-] consumes precious left-side space on mobile, and also makes the method headings stand out less from their section. I'd be interested in experimenting with toggle treatments on mobile as a more thorough fix; for instance only showing them when a section is closed.

@bors
Copy link
Collaborator

bors commented Dec 30, 2021

📌 Commit 7c78ea5 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 31, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 31, 2021
@bors
Auto merge of rust-lang#92465 - matthiaskrgr:rollup-yuary84, r=matthi…
4d2e0fd 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#90383 (Extend check for UnsafeCell in consts to cover unions)
 - rust-lang#91375 (config.rs: Add support for a per-target default_linker option.)
 - rust-lang#91480 (rustdoc: use smaller number of colors to distinguish items)
 - rust-lang#92338 (Add try_reserve and  try_reserve_exact for OsString)
 - rust-lang#92405 (Add a couple needs-asm-support headers to tests)
 - rust-lang#92435 (Sync rustc_codegen_cranelift)
 - rust-lang#92440 (Fix mobile toggles position)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2da54c7 into rust-lang:master Jan 1, 2022
@rustbot rustbot added this to the 1.59.0 milestone Jan 1, 2022
@GuillaumeGomez GuillaumeGomez deleted the fix-mobile-toggles branch January 1, 2022 09:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@jsha jsha

Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rust-highfive @jsha @bors @rustbot