-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Fix a missing dot in the main item heading #92864
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Some changes occurred in HTML/CSS/JS. |
r? @jsha (rust-highfive has picked a reviewer for you, use r? to override) |
Thanks for the fix!
|
Why adding another character? It's already taking more space than before and the toggle is different enough, no? |
I mean "mandatory for the html generation not necessarily for the browser", but it think it also make sense to dot break here.
I tried many things: breaking before, after, trim, no trim, spaces, ... but the only thing that worked was to add a html entity after the space I think this is because of the Askama directives are messing with the spaces/tabs/newline. |
42fb83e
to
0ac89ce
Compare
Then nevermind me. :) |
I think what you want is:
Notice that the "comment" at the end is |
0ac89ce
to
d5871d0
Compare
Oh! I tough this way the other way around, no wonder why it didn't worked when I tested it. Remove the |
@bors r+ rollup Thanks so much! |
📌 Commit d5871d0 has been approved by |
Fix a missing dot in the main item heading This pull-request fix a missing `·` in the item header ~~and also make use of ` ` to explicit that the spaces are mandatory~~. | Before | After | | --- | --- | |  |  | PS: This was introduce yesterday by rust-lang#92526 (the migration from Tera to Askama) and is not currently observable in the nightly doc.
Fix a missing dot in the main item heading This pull-request fix a missing `·` in the item header ~~and also make use of ` ` to explicit that the spaces are mandatory~~. | Before | After | | --- | --- | |  |  | PS: This was introduce yesterday by rust-lang#92526 (the migration from Tera to Askama) and is not currently observable in the nightly doc.
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#92045 (Don't fall back to crate-level opaque type definitions.) - rust-lang#92381 (Suggest `return`ing tail expressions in async functions) - rust-lang#92768 (Partially stabilize `maybe_uninit_extra`) - rust-lang#92810 (Deduplicate box deref and regular deref suggestions) - rust-lang#92818 (Update documentation for doc_cfg feature) - rust-lang#92840 (Fix some lints documentation) - rust-lang#92849 (Clippyup) - rust-lang#92854 (Use the updated Rust logo in rustdoc) - rust-lang#92864 (Fix a missing dot in the main item heading) Failed merges: - rust-lang#92838 (Clean up some links in RELEASES) r? `@ghost` `@rustbot` modify labels: rollup
This pull-request fix a missing
·
in the item headerand also make use of.
to explicit that the spaces are mandatoryPS: This was introduce yesterday by #92526 (the migration from Tera to Askama) and is not currently observable in the nightly doc.