Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update pulldown-cmark version to fix markdown list issue #93012

Merged
merged 2 commits into from
Jan 22, 2022

Conversation

GuillaumeGomez
Copy link
Member

Fixes #92971.

r? @camelid

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 17, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2022
@camelid
Copy link
Member

camelid commented Jan 17, 2022

cc @rust-lang/clippy, but this is just a patch release

Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Clippy part looks good to me 👍

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 18, 2022

Should we approve it then or is there something else to be done here?

@klensy
Copy link
Contributor

klensy commented Jan 18, 2022

Maybe bump mdbook too, to dedupe pulldown-cmark?

@GuillaumeGomez
Copy link
Member Author

I'll send a PR there then. Thanks!

@GuillaumeGomez
Copy link
Member Author

Updated in rust-lang/mdBook#1729.

@klensy
Copy link
Contributor

klensy commented Jan 18, 2022

Updated in rust-lang/mdBook#1729.

I'm talked about bumping it here in rustbook crate, but it's good too.

@GuillaumeGomez
Copy link
Member Author

Updated in rust-lang/mdBook#1729.

I'm talked about bumping it here in rustbook crate, but it's good too.

It's not a direct dependency apparently. You meant to update it from one of its dependencies?

@klensy
Copy link
Contributor

klensy commented Jan 18, 2022

It's not a direct dependency apparently. You meant to update it from one of its dependencies?

$ cargo update -p mdbook
    Updating crates.io index
    Updating mdbook v0.4.14 -> v0.4.15
    Removing pulldown-cmark v0.8.0

@GuillaumeGomez
Copy link
Member Author

Done, thanks for the command!

Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@camelid
Copy link
Member

camelid commented Jan 22, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 22, 2022

📌 Commit 80b26bd has been approved by camelid

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2022
@camelid camelid added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 22, 2022
@camelid
Copy link
Member

camelid commented Jan 22, 2022

This regression is on beta, so nominating for backport.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2022
…elid

Update pulldown-cmark version to fix markdown list issue

Fixes rust-lang#92971.

r? `@camelid`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2022
…elid

Update pulldown-cmark version to fix markdown list issue

Fixes rust-lang#92971.

r? ``@camelid``
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2022
…askrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#85967 (add support for the l4-bender linker on the x86_64-unknown-l4re-uclibc tier 3 target)
 - rust-lang#92828 (Print a helpful message if unwinding aborts when it reaches a nounwind function)
 - rust-lang#93012 (Update pulldown-cmark version to fix markdown list issue)
 - rust-lang#93116 (Simplify use of `map_or`)
 - rust-lang#93132 (Increase the format version of rustdoc-json-types)
 - rust-lang#93147 (Interner cleanups)
 - rust-lang#93153 (Reject unsupported naked functions)
 - rust-lang#93170 (Add missing GUI test explanations)
 - rust-lang#93172 (rustdoc: remove dashed underline under main heading)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f8335d9 into rust-lang:master Jan 22, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 22, 2022
@GuillaumeGomez GuillaumeGomez deleted the pulldown-list branch January 22, 2022 22:19
@camelid camelid added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 25, 2022
@camelid
Copy link
Member

camelid commented Jan 25, 2022

Backport accepted on Zulip here.

ehuss pushed a commit to ehuss/rust that referenced this pull request Jan 25, 2022
…elid

Update pulldown-cmark version to fix markdown list issue

Fixes rust-lang#92971.

r? ```@camelid```
@ehuss ehuss mentioned this pull request Jan 25, 2022
@ehuss ehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 25, 2022
@ehuss ehuss modified the milestones: 1.60.0, 1.59.0 Jan 25, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 26, 2022
[beta] Backports

* Update cargo
    * rust-lang/cargo#10328 — remove --host flag
    * rust-lang/cargo#10325 — Fix documenting with undocumented dependencies
* rust-lang#93128 — Add script to prevent point releases with same number as existing ones
* rust-lang#93014 — Revert "Do not hash leading zero bytes of i64 numbers in Sip128 hasher"
* rust-lang#93012 — Update pulldown-cmark version to fix markdown list issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: some nested lists are rendered incorrectly
8 participants