Skip to content

Update sha1, sha2, and md-5 dependencies #93863

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

pierwill
Copy link
Member

@pierwill pierwill commented Feb 10, 2022

This replaces the deprecated cpuid-bool dependency with cpufeatures, while adding crypto-common as a new dependency.

Closes #93676.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 10, 2022
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2022
@rust-log-analyzer

This comment has been minimized.

@pierwill

This comment was marked as off-topic.

@klensy
Copy link
Contributor

klensy commented Feb 10, 2022

But this didn't replaces cpuid-bool, as it still presented in Cargo.lock? Plus, this does 2x and 3x for some crate versions, as there still some crates slow on updating, like pest-parser/pest#485

@pierwill
Copy link
Member Author

But this didn't replaces cpuid-bool

Fixed 👍

@klensy
Copy link
Contributor

klensy commented Feb 10, 2022

As TODO, we can try to see if there any perf changes for for different features, like this

@klensy
Copy link
Contributor

klensy commented Feb 11, 2022

Btw, you can bump md-5 too, as it depends on the same crates.

@pierwill pierwill changed the title Update sha1 and sha2 dependencies Update sha1, sha2, and md-5 dependencies Feb 11, 2022
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2022
@pierwill
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 13, 2022
This removes the `cpuid-bool` dependency, which is deprecated,
while adding `crypto-common` as a new dependency.
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Feb 14, 2022

📌 Commit ef6dd12 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2022
@bors
Copy link
Collaborator

bors commented Feb 15, 2022

⌛ Testing commit ef6dd12 with merge 8d163e6...

@bors
Copy link
Collaborator

bors commented Feb 15, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 8d163e6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 15, 2022
@bors bors merged commit 8d163e6 into rust-lang:master Feb 15, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 15, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8d163e6): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@pierwill pierwill deleted the fix-93676 branch February 15, 2022 16:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated dependency in tidy's deps.rs
9 participants