Skip to content

Rollup of 5 pull requests #94405

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 12 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

est31 and others added 12 commits February 19, 2022 01:20
…jgillot

rustc_trait_selection: adopt let else in more places

Continuation of rust-lang#89933, rust-lang#91018, rust-lang#91481, rust-lang#93046, rust-lang#93590, rust-lang#94011.

I have extended my clippy lint to also recognize tuple passing and match statements. The diff caused by fixing it is way above 1 thousand lines. Thus, I split it up into multiple pull requests to make reviewing easier. This PR handles rustc_trait_selection.
Fix show error message when literal overflows in match patterns

Fix rust-lang#94239
This changes overflow behavior in [fn lit_to_const](https://github.com/rust-lang/rust/blob/master/compiler/rustc_mir_build/src/thir/constant.rs#L10)
…ion, r=cjgillot

Document that pre-expansion lint passes are softly deprecated

The pre-expansion lint pass has been softly deprecated since rust-lang#69838. Every once in a while I see someone mention it as a possibility, only get the feedback that it's deprecated. This PR officially documents that the method is soft deprecated to have a single point of truth for it.

That's it. Have a great rest of the day 🙃

---

* See [rust#69838](rust-lang#69838)
* See [rust-clippy#5518](rust-lang/rust-clippy#5518)
…5, r=matthiaskrgr

Add test for rust-lang#79465 to prevent regression

Fixes rust-lang#79465.

Like this we will be able to close the issue.

r? `@matthiaskrgr`
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Feb 26, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Feb 26, 2022

📌 Commit 57488db has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 26, 2022
@bors
Copy link
Collaborator

bors commented Feb 27, 2022

⌛ Testing commit 57488db with merge 5386b01ef0e6420c5ab1b5a6eda4fdc7a3b3e45c...

@rust-log-analyzer
Copy link
Collaborator

The job dist-i586-gnu-i586-i686-musl failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Dropping 2
Dropping 3
Dropping 4
------------------------------------------
--- stderr -------------------------------
thread '<unnamed>' panicked at 'Oh no', /checkout/src/test/ui/array-slice-vec/box-of-array-of-drop-1.rs:31:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'expect: 0xffffffff actual: 0x56781234', /checkout/src/test/ui/array-slice-vec/box-of-array-of-drop-1.rs:52:5


---- [ui] ui/array-slice-vec/box-of-array-of-drop-2.rs stdout ----

---
Dropping 2
Dropping 3
Dropping 4
------------------------------------------
--- stderr -------------------------------
thread '<unnamed>' panicked at 'Oh no', /checkout/src/test/ui/array-slice-vec/box-of-array-of-drop-2.rs:31:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'expect: 0xffffffff actual: 0x56781234', /checkout/src/test/ui/array-slice-vec/box-of-array-of-drop-2.rs:52:5


---- [ui] ui/array-slice-vec/nested-vec-3.rs stdout ----

---
Dropping 2
Dropping 3
Dropping 4
------------------------------------------
--- stderr -------------------------------
thread '<unnamed>' panicked at 'Oh no', /checkout/src/test/ui/array-slice-vec/nested-vec-3.rs:32:21
Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=i586-unknown-linux-gnu
Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=i586-unknown-linux-gnu
thread 'main' panicked at 'expect: 0xffffffff actual: 0x56781234', /checkout/src/test/ui/array-slice-vec/nested-vec-3.rs:59:5



failures:

@bors
Copy link
Collaborator

bors commented Feb 27, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2022
@matthiaskrgr matthiaskrgr deleted the rollup-qxe9xhs branch March 11, 2022 15:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants