Update browser-ui-test version to 0.8.3 #95013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
I think your NPM package is broken. The |
|
Indeed, great catch! I'll update the PR once I have fixed this. |
GuillaumeGomez
force-pushed
the
browser-ui-test-v
branch
from
4d680ea to
45a3075
Compare
|
Again, thanks a lot @notriddle! I added a second commit which will run GUI test if browser-ui-test version is updated to ensure that this issue will never happen. |
|
@bors r+ rollup=always |
|
📌 Commit 45a3075 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2022
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#95013 (Update browser-ui-test version to 0.8.2) - rust-lang#95039 (Make negative coherence work when there's impl negative on super predicates) - rust-lang#95047 (Refactor: remove an unnecessary pattern for ignoring all parts) - rust-lang#95048 (update Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It brings mostly debugging improvements: it doesn't stop at the first failing command but rather at the first "fatal error".
r? @notriddle