-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Make negative coherence work when there's impl negative on super predicates #95039
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit and one question, then r=me
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3dbe419
to
9c076f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with FIXME removed
@bors r+ |
📌 Commit 89a00cc has been approved by |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#95013 (Update browser-ui-test version to 0.8.2) - rust-lang#95039 (Make negative coherence work when there's impl negative on super predicates) - rust-lang#95047 (Refactor: remove an unnecessary pattern for ignoring all parts) - rust-lang#95048 (update Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
r? @nikomatsakis