Reduce the amount of unstable features used in libproc_macro #95308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
commented
Mar 25, 2022
bjorn3
commented
Mar 25, 2022
| } | ||
|
|
||
| impl<'a, A, R> !Sync for Closure<'a, A, R> {} | ||
| impl<'a, A, R> !Send for Closure<'a, A, R> {} | ||
| struct Env; |
There was a problem hiding this comment.
The rust-analyzer copies turn Env into a regular struct too, but don't replace &mut Env with *mut Env, which is UB according to stacked borrows.
|
Looks like rustbot and gha are borked. r? @Mark-Simulacrum as suggested by github |
est31
reviewed
Mar 25, 2022
bjorn3
force-pushed
the
more_stable_proc_macro
branch
from
b06dbfe to
6702a9b
Compare
bjorn3
force-pushed
the
more_stable_proc_macro
branch
from
6702a9b to
6eab980
Compare
bjorn3
added
the
S-waiting-on-review
Mark-Simulacrum
added
S-waiting-on-author
bjorn3
added
S-waiting-on-review
|
@bors r+ |
|
Bors didn't respond. @bors r=Mark-Simulacrum |
|
@bors r=Mark-Simulacrum |
|
📌 Commit 7eda975 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#95308 (Reduce the amount of unstable features used in libproc_macro) - rust-lang#95676 (Update RLS) - rust-lang#95769 (Hide cross-crate `#[doc(hidden)]` associated items in trait impls) - rust-lang#95785 (interpret: err instead of ICE on size mismatches in to_bits_or_ptr_internal) - rust-lang#95802 (fix unused constant warning on some Windows targets) - rust-lang#95810 (Use `format-args-capture` and remove unnecessary nested blocks) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to adapt the source for stable when copying it into rust-analyzer to load rustc compiled proc macros.