Hide cross-crate #[doc(hidden)] associated items in trait impls
#95769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
rustbot
added
the
A-cross-crate-reexports
|
Other than the test, it looks good to me, thanks! cc @camelid to double check the code changes. |
fmease
commented
Apr 7, 2022
fmease
commented
Apr 7, 2022
src/test/rustdoc/auxiliary/cross-crate-hidden-assoc-trait-items.rs
Outdated
Show resolved
Hide resolved
fmease
force-pushed
the
fix-issue-95717
branch
2 times, most recently
from
bbe3da1 to
80be793
Compare
|
@GuillaumeGomez Sorry, I don't have time to review this, but nothing stood out when I glanced at the diff. I'll leave it to you :) |
GuillaumeGomez
approved these changes
Apr 8, 2022
|
📌 Commit 4623d51 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 8, 2022
…Gomez Hide cross-crate `#[doc(hidden)]` associated items in trait impls Fixes rust-lang#95717. r? `@GuillaumeGomez` This is the bug I ran into in rust-lang#95316. `@rustbot` label T-rustdoc A-cross-crate-reexports
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 9, 2022
…Gomez Hide cross-crate `#[doc(hidden)]` associated items in trait impls Fixes rust-lang#95717. r? ``@GuillaumeGomez`` This is the bug I ran into in rust-lang#95316. ``@rustbot`` label T-rustdoc A-cross-crate-reexports
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#95308 (Reduce the amount of unstable features used in libproc_macro) - rust-lang#95676 (Update RLS) - rust-lang#95769 (Hide cross-crate `#[doc(hidden)]` associated items in trait impls) - rust-lang#95785 (interpret: err instead of ICE on size mismatches in to_bits_or_ptr_internal) - rust-lang#95802 (fix unused constant warning on some Windows targets) - rust-lang#95810 (Use `format-args-capture` and remove unnecessary nested blocks) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95717.
r? @GuillaumeGomez
This is the bug I ran into in #95316.
@rustbot label T-rustdoc A-cross-crate-reexports