rustdoc: Fix item info display overflow

[GuillaumeGomez]

I came across this issue when reading local Iterator docs (reproduced in this screenshot):

The problem comes from the fact that span isn't display: block by default. Since item-info was already present on <div> in other places, I moved the last one to div as well.

r? @notriddle

[rust-highfive]

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

[notriddle]

@bors r+

[bors]

📌 Commit 41b0247 has been approved by notriddle

[jsha]

I think this is not the right fix. I originally changed this from a <div> to a <span> in 32f62607c314 in order to make our HTML valid. The item-info appears inside an <summary>, and those are not allowed to contain <div>. The idea there was to apply display: block to the span.

If the <span> is not getting display: block maybe we could fix the CSS instead?

[notriddle]

I'd be fine with that, but if we're going to pursue valid HTML, then we really should also add automated tests to ensure we don't accidentally regress.

[GuillaumeGomez]

I think this is not the right fix. I originally changed this from a <div> to a <span> in 32f62607c314 in order to make our HTML valid. The item-info appears inside an <summary>, and those are not allowed to contain <div>. The idea there was to apply display: block to the span.

If the <span> is not getting display: block maybe we could fix the CSS instead?

I went with that originally but ended up with switching to div for coherency. I'll make it the other way then with a fix to the CSS.

[jsha]

if we're going to pursue valid HTML, then we really should also add automated tests to ensure we don't accidentally regress.

Totally agreed; I took a shortcut on the previous PR because it seemed like it was going to be hard to get htmltidy (https://github.com/htacg/tidy-html5) integrated into the CI runners. But I should do the work and get it done. :-)

[GuillaumeGomez]

I opened #95738 to switch all item-info items to span and made the CSS change.