Skip to content

Switch item-info from div to span #95738

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

GuillaumeGomez
Copy link
Member

Following discussion in #95684.

cc @jsha
r? @notriddle

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 6, 2022
@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2022
@notriddle
Copy link
Contributor

I'm fine either way. I don't really care about whether our HTML is "valid" or not, as long as spec-compliant HTML5 parsers can read it.

However, if y'all want valid HTML, I won't do anything to stop you. Just please get HTML Tidy to run in the CI environment so that we stop accidentally regressing.

@GuillaumeGomez
Copy link
Member Author

That'd be nice, indeed...

@jsha
Copy link
Contributor

jsha commented Apr 6, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 6, 2022

📌 Commit 56d0f94 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95185 (Stabilize Stdin::lines.)
 - rust-lang#95626 (Don't cast thread name to an integer for prctl)
 - rust-lang#95709 (Improve terse test output.)
 - rust-lang#95735 (Revert "Mark Location::caller() as #[inline]")
 - rust-lang#95738 (Switch item-info from div to span)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fe6d69f into rust-lang:master Apr 7, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 7, 2022
@GuillaumeGomez GuillaumeGomez deleted the item-info-switch-to-span branch April 7, 2022 08:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants