Skip to content

resolve: Create dummy bindings for all unresolved imports #95887

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2022
Merged

resolve: Create dummy bindings for all unresolved imports #95887

merged 1 commit into from
Apr 16, 2022

Conversation

petrochenkov
Copy link
Contributor

Apparently such bindings weren't previously created for all unresolved imports, causing issues like #95879.
In this PR I'm trying to create such dummy bindings in a more centralized way by calling import_dummy_binding once for all imports in finalize_imports.

Fixes #95879.

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 10, 2022
@rust-highfive
Copy link
Contributor

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2022
@petrochenkov petrochenkov mentioned this pull request Apr 10, 2022
Closed
@petrochenkov petrochenkov mentioned this pull request Apr 13, 2022
Open
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 15, 2022

📌 Commit 09195d3 has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2022
@bors
Auto merge of rust-lang#96117 - Dylan-DPC:rollup-5traczf, r=Dylan-DPC
d9b3ff7 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#95887 (resolve: Create dummy bindings for all unresolved imports)
 - rust-lang#96023 (couple of clippy::perf fixes)
 - rust-lang#96035 (Update GitHub Actions actions/checkout Version v2 -> v3)
 - rust-lang#96038 (docs: add link from zip to unzip)
 - rust-lang#96047 (:arrow_up: rust-analyzer)
 - rust-lang#96059 (clarify doc(cfg) wording)
 - rust-lang#96081 (Make some `usize`-typed masks definitions agnostic to the size of `usize`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0a8acac into rust-lang:master Apr 16, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 16, 2022
@ouz-a ouz-a mentioned this pull request Jun 15, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 24, 2022
@Dylan-DPC
Rollup merge of rust-lang#98145 - ouz-a:some_branch, r=oli-obk
84c2c51 
Pull Derefer before ElaborateDrops

_Follow up work to rust-lang#97025 rust-lang#96549 rust-lang#96116 rust-lang#95887 #95649_

This moves `Derefer` before `ElaborateDrops` and creates a new `Rvalue` called `VirtualRef` that allows us to bypass many constraints for `DerefTemp`.

r? `@oli-obk`
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 25, 2022
@Dylan-DPC
Rollup merge of rust-lang#98145 - ouz-a:some_branch, r=oli-obk
9a3ac98 
Pull Derefer before ElaborateDrops

_Follow up work to rust-lang#97025 rust-lang#96549 rust-lang#96116 rust-lang#95887 #95649_

This moves `Derefer` before `ElaborateDrops` and creates a new `Rvalue` called `VirtualRef` that allows us to bypass many constraints for `DerefTemp`.

r? ``@oli-obk``
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 12, 2022
@Dylan-DPC
Rollup merge of rust-lang#98145 - ouz-a:some_branch, r=oli-obk
ac5fc23 
Pull Derefer before ElaborateDrops

_Follow up work to rust-lang#97025 rust-lang#96549 rust-lang#96116 rust-lang#95887 #95649_

This moves `Derefer` before `ElaborateDrops` and creates a new `Rvalue` called `VirtualRef` that allows us to bypass many constraints for `DerefTemp`.

r? `@oli-obk`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 13, 2022
@bors
Auto merge of rust-lang#98145 - ouz-a:some_branch, r=oli-obk
42bd138 
Pull Derefer before ElaborateDrops

_Follow up work to rust-lang#97025 rust-lang#96549 rust-lang#96116 rust-lang#95887 #95649_

This moves `Derefer` before `ElaborateDrops` and creates a new `Rvalue` called `VirtualRef` that allows us to bypass many constraints for `DerefTemp`.

r? `@oli-obk`
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 18, 2022
@bors
Auto merge of rust-lang#98145 - ouz-a:some_branch, r=oli-obk
4e3a7bf 
Pull Derefer before ElaborateDrops

_Follow up work to rust-lang#97025 rust-lang#96549 rust-lang#96116 rust-lang#95887 #95649_

This moves `Derefer` before `ElaborateDrops` and creates a new `Rvalue` called `VirtualRef` that allows us to bypass many constraints for `DerefTemp`.

r? `@oli-obk`
@petrochenkov petrochenkov deleted the doclink5 branch February 22, 2025 18:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

rustdoc ice: 'internal error: entered unreachable code', compiler/rustc_resolve/src/lib.rs:3305:6
5 participants
@petrochenkov @rust-highfive @cjgillot @bors @rustbot