Move Derefer before Retag #96549
Merged
Move Derefer before Retag #96549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
ouz-a
commented
Apr 29, 2022
ouz-a
commented
Apr 29, 2022
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Apr 29, 2022
oli-obk
reviewed
Apr 29, 2022
|
some style nits and CI is unhappy with the |
oli-obk
added
S-waiting-on-author
|
@bors r+ |
|
📌 Commit d9ddb64 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (6eda764): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
RalfJung
reviewed
May 9, 2022
| @@ -57,6 +57,17 @@ fn may_be_reference(ty: Ty<'_>) -> bool { | |||
| } | |||
| } | |||
|
|
|||
| /// Determines whether or not this LocalDecl is temp, if not it needs retagging. | |||
| fn is_not_temp<'tcx>(local_decl: &LocalDecl<'tcx>) -> bool { | |||
There was a problem hiding this comment.
is_temp would be slightly clearer I think; return false inside this function is a double negation which is somewhat confusing.
There was a problem hiding this comment.
You are right, I will change this function in the next update of derefer.
RalfJung
reviewed
May 9, 2022
| @@ -1079,6 +1079,8 @@ pub enum LocalInfo<'tcx> { | |||
| /// A temporary created during the creation of an aggregate | |||
| /// (e.g. a temporary for `foo` in `MyStruct { my_field: foo }`) | |||
| AggregateTemp, | |||
| /// A temporary created during the pass `Derefer` to avoid it's retagging | |||
There was a problem hiding this comment.
(should be "its retagging"... not a big deal though)
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 28, 2022
…idtwco Add validation layer for Derefer _Follow up work to rust-lang#96549 rust-lang#96116 rust-lang#95857 #95649_ This adds validation for Derefer making sure it is always the first projection. r? rust-lang/mir-opt
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 30, 2022
…twco Add validation layer for Derefer _Follow up work to rust-lang#96549 rust-lang#96116 rust-lang#95857 #95649_ This adds validation for Derefer making sure it is always the first projection. r? rust-lang/mir-opt
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 24, 2022
Pull Derefer before ElaborateDrops _Follow up work to rust-lang#97025 rust-lang#96549 rust-lang#96116 rust-lang#95887 #95649_ This moves `Derefer` before `ElaborateDrops` and creates a new `Rvalue` called `VirtualRef` that allows us to bypass many constraints for `DerefTemp`. r? `@oli-obk`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 25, 2022
Pull Derefer before ElaborateDrops _Follow up work to rust-lang#97025 rust-lang#96549 rust-lang#96116 rust-lang#95887 #95649_ This moves `Derefer` before `ElaborateDrops` and creates a new `Rvalue` called `VirtualRef` that allows us to bypass many constraints for `DerefTemp`. r? ``@oli-obk``
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 12, 2022
Pull Derefer before ElaborateDrops _Follow up work to rust-lang#97025 rust-lang#96549 rust-lang#96116 rust-lang#95887 #95649_ This moves `Derefer` before `ElaborateDrops` and creates a new `Rvalue` called `VirtualRef` that allows us to bypass many constraints for `DerefTemp`. r? `@oli-obk`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 13, 2022
Pull Derefer before ElaborateDrops _Follow up work to rust-lang#97025 rust-lang#96549 rust-lang#96116 rust-lang#95887 #95649_ This moves `Derefer` before `ElaborateDrops` and creates a new `Rvalue` called `VirtualRef` that allows us to bypass many constraints for `DerefTemp`. r? `@oli-obk`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 18, 2022
Pull Derefer before ElaborateDrops _Follow up work to rust-lang#97025 rust-lang#96549 rust-lang#96116 rust-lang#95887 #95649_ This moves `Derefer` before `ElaborateDrops` and creates a new `Rvalue` called `VirtualRef` that allows us to bypass many constraints for `DerefTemp`. r? `@oli-obk`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up work to #96116 #95857 #95649
This moves
DereferbeforeRetagand creates a newLocalInfocalledTempto avoid retagging created temp values.Zulip discussion link
r? @oli-obk