Skip to content

add file_suffix method to std::path #97134

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add file_suffix method to std::path #97134

wants to merge 1 commit into from

Conversation

EvanCarroll
Copy link

@EvanCarroll EvanCarroll commented May 18, 2022 •
edited
Loading

This adds file_suffix as suggested in #86319. file_prefix was added in #85166.

I wanted the file_suffix to be everything that's NOT the file_prefix.

For foo.tar.gz, foo is the file_prefix. .tar.gz is the file_suffix.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 18, 2022
@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2022
@EvanCarroll
Copy link
Author

I can write tests if this implementation is approved in #86319

@the8472 the8472 added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 29, 2022
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2022
@JohnCSimon
Copy link
Member

Triage:
@EvanCarroll - I guess this is still waiting on #86319 ?

@bors
Copy link
Collaborator

bors commented Sep 21, 2022

☔ The latest upstream changes (presumably #102097) made this pull request unmergeable. Please resolve the merge conflicts.

@joshtriplett
Copy link
Member

This seems fine to me as a companion to file_prefix.

Please do rebase and add tests.

@joshtriplett joshtriplett added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2022
@JohnCSimon
Copy link
Member

This seems fine to me as a companion to file_prefix.

Please do rebase and add tests.

@EvanCarroll ☝️

@JohnCSimon
Copy link
Member

@EvanCarroll

ping from triage - can you post your status on this PR? There hasn't been an update in a few months. Thanks!

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

@EvanCarroll
Copy link
Author

Sorry, I forgot about this thanks for the ping I'll give it a go.

@JohnCSimon
Copy link
Member

@EvanCarroll

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you are going to continue please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Jun 17, 2023
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Jun 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@EvanCarroll @rust-highfive @JohnCSimon @bors @joshtriplett @the8472 @rustbot