Skip to content

add file_suffix method to std::path #97134

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion library/std/src/path.rs
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ fn split_file_at_dot(file: &OsStr) -> (&OsStr, Option<&OsStr>) {
None => return (file, None),
};
let before = &slice[..i];
let after = &slice[i + 1..];
let after = &slice[i..];
unsafe { (u8_slice_as_os_str(before), Some(u8_slice_as_os_str(after))) }
}

Expand Down Expand Up @@ -2392,6 +2392,8 @@ impl Path {
/// # See Also
/// This method is similar to [`Path::file_stem`], which extracts the portion of the file name
/// before the *last* `.`
/// This method is the prefix-analog of [`Path::file_suffix`], which extracts the portion of the file name
/// before the *first* `.`
///
/// [`Path::file_stem`]: Path::file_stem
///
Expand All @@ -2401,6 +2403,42 @@ impl Path {
self.file_name().map(split_file_at_dot).and_then(|(before, _after)| Some(before))
}

/// Extracts the suffix of [`self.file_name`].
///
/// The suffix is:
///
/// * [`None`], if there is no file name;
/// * [`None`] if there is no embedded `.`;
/// * The portion of the file name after and including the first non-beginning `.`;
/// * [`None`] if the file name begins with `.` and has no other `.`s within;
/// * The portion of the file name after the second `.` if the file name begins with `.`
///
/// [`self.file_name`]: Path::file_name
///
/// # Examples
///
/// ```
/// # #![feature(path_file_suffix)]
/// use std::path::Path;
///
/// assert_eq!(".rs", Path::new("foo.rs").file_suffix().unwrap());
/// assert_eq!(".tar.gz", Path::new("foo.tar.gz").file_suffix().unwrap());
/// ```
///
/// # See Also
/// This method is similar to [`Path::extension`], which extracts the portion of the file name
/// after the *last* `.`
/// This method is the suffix-analog of [`Path::file_prefix`], which extracts the portion of the file name
/// before the *first* `.`
///
/// [`Path::extension`]: Path::extension
///
#[unstable(feature = "path_file_suffix", issue = "86319")]
#[must_use]
pub fn file_suffix(&self) -> Option<&OsStr> {
self.file_name().map(split_file_at_dot).and_then(|(_before, after)| after)
}

/// Extracts the extension of [`self.file_name`], if possible.
///
/// The extension is:
Expand Down