Rollup of 5 pull requests #97637
Closed
Rollup of 5 pull requests #97637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change was "Show invisible delimiters (within comments) when pretty printing". It's useful to show these delimiters, but is a breaking change for some proc macros. Fixes rust-lang#97608.
Diagnose anonymous lifetimes errors more uniformly between async and regular fns Async fns and regular fns are desugared differently. For the former, we create a generic parameter at HIR level. For the latter, we just create an anonymous region for typeck. I plan to migrate regular fns to the async fn desugaring. Before that, this PR attempts to merge the diagnostics for both cases. r? ``@estebank``
…=Mark-Simulacrum Stabilize `box_into_pin` FCP has been completed: rust-lang#62370 (comment) Also, adds notes as per rust-lang#62370 (comment) Closes rust-lang#62370
…stage-2, r=davidtwco Migrate more diagnostics to use the `#[derive(SessionDiagnostic)]` r? `@davidtwco`
…ftSpider Fix JSON reexport ICE Fixes rust-lang#97432. The problem was that the ID was conflicting because the reexports have the same one. To fix it, I "extended" it by adding the `Symbol` into it as well. r? `@notriddle`
Revert rust-lang#96682. The change was "Show invisible delimiters (within comments) when pretty printing". It's useful to show these delimiters, but is a breaking change for some proc macros. Fixes rust-lang#97608. r? `@petrochenkov`
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
|
📌 Commit 249ffc0 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 249ffc0 with merge 011f1379850976cb3e86d255f5905868662db928... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
box_into_pin#97397 (Stabilizebox_into_pin)#[derive(SessionDiagnostic)]#97587 (Migrate more diagnostics to use the#[derive(SessionDiagnostic)])Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup