Revert #96682. #97636
Merged
Revert #96682. #97636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change was "Show invisible delimiters (within comments) when pretty printing". It's useful to show these delimiters, but is a breaking change for some proc macros. Fixes rust-lang#97608.
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
cc @dtolnay |
|
@bors r+ |
|
📌 Commit 77e1069 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 2, 2022
Revert rust-lang#96682. The change was "Show invisible delimiters (within comments) when pretty printing". It's useful to show these delimiters, but is a breaking change for some proc macros. Fixes rust-lang#97608. r? `@petrochenkov`
wesleywiser
added
the
beta-nominated
|
Nominating for beta backport as #97608 is a stable-to-beta regression. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 2, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#97420 (Be a little nicer with casts when formatting `fn` pointers) - rust-lang#97450 ([RFC 2011] Basic compiler infrastructure) - rust-lang#97599 (Fix JSON reexport ICE) - rust-lang#97617 (Rustdoc anonymous reexports) - rust-lang#97636 (Revert rust-lang#96682.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
rustbot
added
the
beta-accepted
|
@apiraino: Do I need to do anything to effect the beta backport? |
|
No, unless there are merge conflicts, but the actual backport will be taken care of by release or someone else. |
ehuss
pushed a commit
to ehuss/rust
that referenced
this pull request
Jun 24, 2022
Revert rust-lang#96682. The change was "Show invisible delimiters (within comments) when pretty printing". It's useful to show these delimiters, but is a breaking change for some proc macros. Fixes rust-lang#97608. r? ``@petrochenkov``
Merged
ehuss
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2022
[beta] Beta backports * Remove the unused-#[doc(hidden)] logic from the unused_attributes lint rust-lang#98336 * debuginfo: Fix NatVis for Rc and Arc with unsized pointees. rust-lang#98137 * Revert "remove num_cpus dependency" in rustc and update cargo rust-lang#97911 * Update LLVM submodule rust-lang#97690 * Revert rust-lang#96682. rust-lang#97636 * don't do Sized and other return type checks on RPIT's real type rust-lang#97431 * Temporarily disable submodule archive downloads. rust-lang#98423
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change was "Show invisible delimiters (within comments) when pretty
printing". It's useful to show these delimiters, but is a breaking
change for some proc macros.
Fixes #97608.
r? @petrochenkov