Skip to content

Temporarily disable submodule archive downloads. #98423

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

Temporarily disable submodule archive downloads. #98423

merged 1 commit into from
Jun 23, 2022

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jun 23, 2022

The llvm-project /archive/ download has been timing out with a 504 error since yesterday. This changes it so that it uses a normal submodule clone, but also uses --depth 1 since GitHub now supports allowReachableSHA1InWant which allows for fetching a specific revision. That should be reasonably fast (but not as fast as an archive download) to unstick CI.

@rust-highfive
Copy link
Contributor

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2022
@Dylan-DPC
Copy link
Member

@bors r+ p=10001

@bors
Copy link
Collaborator

bors commented Jun 23, 2022

📌 Commit 7106d1e9552558e3c8a676ff93523f9f1fa9397f has been approved by Dylan-DPC

@bors
Copy link
Collaborator

bors commented Jun 23, 2022

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2022
@bors
Copy link
Collaborator

bors commented Jun 23, 2022

🛑 Priority higher than 9001 is ignored.

@Dylan-DPC
Copy link
Member

@bors p=1001

@bors
Copy link
Collaborator

bors commented Jun 23, 2022

⌛ Testing commit 7106d1e9552558e3c8a676ff93523f9f1fa9397f with merge 9eb6a304247413e4e019a7c8800aa532fddacc2b...

@bors
Copy link
Collaborator

bors commented Jun 23, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 23, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
@ehuss ehuss force-pushed the ci-submodule-no-archive branch from 7106d1e to ebfde3c Compare June 23, 2022 17:44
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 23, 2022

📌 Commit ebfde3c has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2022
@bors
Copy link
Collaborator

bors commented Jun 23, 2022

⌛ Testing commit ebfde3c with merge 4334739...

@bors
Copy link
Collaborator

bors commented Jun 23, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 4334739 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 23, 2022
@bors bors merged commit 4334739 into rust-lang:master Jun 23, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 23, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4334739): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 0.3% 0.3% 2
Regressions 😿
(secondary)		 0.7% 0.8% 6
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 0.3% 0.3% 2

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 5.5% 5.5% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.4% -2.7% 2
Improvements 🎉
(secondary)		 -3.2% -5.3% 2
All 😿🎉 (primary) 0.2% 5.5% 3

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.8% 2.8% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot added the perf-regression Performance regression. label Jun 23, 2022
ehuss pushed a commit to ehuss/rust that referenced this pull request Jun 24, 2022
@bors @ehuss
Auto merge of rust-lang#98423 - ehuss:ci-submodule-no-archive, r=comp…
31eb5f7 
…iler-errors

Temporarily disable submodule archive downloads.

The `llvm-project` `/archive/` download has been timing out with a 504 error since yesterday. This changes it so that it uses a normal submodule clone, but also uses `--depth 1` since GitHub now supports `allowReachableSHA1InWant` which allows for fetching a specific revision. That should be reasonably fast (but not as fast as an archive download) to unstick CI.
@ehuss ehuss mentioned this pull request Jun 24, 2022
Merged
@ehuss ehuss added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 24, 2022
@ehuss ehuss modified the milestones: 1.63.0, 1.62.0 Jun 24, 2022
@ehuss
Copy link
Contributor Author

ehuss commented Jun 24, 2022

Accepting for backport to get CI working on beta.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 24, 2022
@bors
Auto merge of rust-lang#98440 - ehuss:update-beta-cargo, r=ehuss
d8ffc1f 
[beta] Beta backports

* Remove the unused-#[doc(hidden)] logic from the unused_attributes lint rust-lang#98336
* debuginfo: Fix NatVis for Rc and Arc with unsized pointees. rust-lang#98137
* Revert "remove num_cpus dependency" in rustc and update cargo rust-lang#97911
* Update LLVM submodule rust-lang#97690
* Revert rust-lang#96682. rust-lang#97636
* don't do Sized and other return type checks on RPIT's real type rust-lang#97431
* Temporarily disable submodule archive downloads. rust-lang#98423
@rylev
Copy link
Member

rylev commented Jun 28, 2022

Looks like there is some new noise in the keccak benchmark. Marking this as triaged.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jun 28, 2022
@ehuss ehuss mentioned this pull request Jul 26, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 4, 2022
@matthiaskrgr
Rollup merge of rust-lang#99772 - ehuss:reenable-submodule-archive, r…
87dd56f 
…=Mark-Simulacrum

Re-enable submodule archive downloads.

This is effectively a revert of rust-lang#98423 (though it keeps the `--depth 1` flag since that is still helpful).

GitHub has indicated that they have been working on the original issue, and my testing shows that the llvm-project archive download now succeeds 100% of the time.

This should save about a minute on every job.
@pietroalbini pietroalbini mentioned this pull request Jan 10, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
10 participants
@ehuss @rust-highfive @Dylan-DPC @bors @rust-log-analyzer @compiler-errors @rust-timer @rylev @kennytm @rustbot