Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid Symbol to String conversions #99837

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Avoid Symbol to String conversions #99837

merged 1 commit into from
Jul 28, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Jul 28, 2022 •
edited
Loading

follow-up to #99508

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 28, 2022
@rust-highfive
Copy link
Contributor

r? @spastorino

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 28, 2022
@fee1-dead
Copy link
Member

r? @fee1-dead

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 28, 2022

📌 Commit 3cbc944 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#99837 - TaKO8Ki:avoid-symbol-to-string-conv…
2d921a6 
…ersions, r=fee1-dead

Avoid `Symbol` to `String` conversions

follow-up to rust-lang#99508
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 28, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 28, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 28, 2022
@bors
Auto merge of rust-lang#99849 - Dylan-DPC:rollup-1yfpplw, r=Dylan-DPC
e568261 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#99714 (Fix regression introduced with rust-lang#99383)
 - rust-lang#99723 (Allow using stable os::fd::raw items through unstable os::wasi module)
 - rust-lang#99810 (Fix settings slider on small width screens)
 - rust-lang#99837 (Avoid `Symbol` to `String` conversions)
 - rust-lang#99846 (Refactor `UnresolvedImportError`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3a37c9a into rust-lang:master Jul 28, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 28, 2022
@TaKO8Ki TaKO8Ki deleted the avoid-symbol-to-string-conversions branch July 28, 2022 19:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
6 participants
@TaKO8Ki @rust-highfive @fee1-dead @bors @spastorino @rustbot