Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add TryFrom<web_sys::WebSocket> #365

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Add TryFrom<web_sys::WebSocket> #365

merged 2 commits into from
Aug 11, 2023

Conversation

mokeyish
Copy link
Contributor

On server side, websocket may create from WebSocketPair. So we need TryFrom<web_sys::WebSocket>.

https://docs.rs/worker/latest/src/worker/websocket.rs.html#26-31

ranile
ranile requested changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm in favor of adding a way to use an existing web socket instance. There's one comment that about accessing the inner instance that need to be addressed

ranile
ranile approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ranile ranile merged commit fb41389 into rustwasm:master Aug 11, 2023
@carlsverre
Copy link

@hamza1311 is it possible to ship this sometime soon? I would prefer not to pin a git sha

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ranile ranile ranile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mokeyish @carlsverre @ranile