Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add TryFrom<web_sys::WebSocket> #365

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Add TryFrom<web_sys::WebSocket> #365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b17875b
Add `TryFrom<web_sys::WebSocket>`
mokeyish Aug 10, 2023
10d9ad4
Remove `AsRef<web_sys::WebSocket>` impl.
mokeyish Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/net/src/websocket/futures.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,14 @@ impl WebSocket {
}
}

impl TryFrom<web_sys::WebSocket> for WebSocket {
type Error = JsError;

fn try_from(ws: web_sys::WebSocket) -> Result<Self, Self::Error> {
Self::setup(Ok(ws))
}
}

#[derive(Clone)]
enum StreamMessage {
ErrorEvent,
Expand Down