Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

check wasm-bindgen version if target = web is passed #627

Closed
ashleygwilliams opened this issue Apr 12, 2019 · 3 comments
Closed

check wasm-bindgen version if target = web is passed #627

ashleygwilliams opened this issue Apr 12, 2019 · 3 comments
Labels
current release current todo items enhancement New feature or request PR attached there's a PR open for this issue
Milestone
0.9.0

Comments

@ashleygwilliams
Copy link
Member

we've seen some people get confused by the error message about an incorrect argument when wasm-pack build --target web is run on a project that depends on a wasm-bindgen that didn't support that target. we should give an error message that tells folks to update their wasm-bindgen dep in their Cargo.toml.
@ashleygwilliams ashleygwilliams added enhancement New feature or request help wanted Extra attention is needed PR welcome labels Apr 12, 2019
@ashleygwilliams ashleygwilliams added this to the 0.9.0 milestone Apr 12, 2019
gameldar pushed a commit to gameldar/wasm-pack that referenced this issue Apr 21, 2019
rustwasm#627 - create a custom error message when wasm-bindgen fails …
97fdc94 
…because --web isn't available

Change the return type of the child run commands so it can return a CommandError that also captures the stderr if the process fails.
See if the returned output contains the 'Unknown flag: --web' error message and if so provide an alternative error that suggests upgrading
@gameldar gameldar mentioned this issue Apr 21, 2019
Closed
@gameldar
Copy link

After looking through the wasm-bindgen changelog to find the appropriate minimum version of wasm-bindgen to depend upon I was going to create a new issue because --web has been deprecated then found #597 - should I list the minimum as 0.2.40 rather than 0.2.39 so we can potentially move ahead with #597 sooner?

@ashleygwilliams ashleygwilliams added PR attached there's a PR open for this issue and removed PR welcome labels May 16, 2019
@ashleygwilliams ashleygwilliams added current release current todo items and removed help wanted Extra attention is needed labels Jul 16, 2019
@EverlastingBugstopper
Copy link
Contributor

was this fixed by 97fdc94? Looks like it was committed directly to master - if so we should close this

@EverlastingBugstopper
Copy link
Contributor

EverlastingBugstopper commented Jan 7, 2020 •
edited
Loading

@ashleygwilliams this was fixed by #684 - we should close this issue

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
current release current todo items enhancement New feature or request PR attached there's a PR open for this issue
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
3 participants
@gameldar @ashleygwilliams @EverlastingBugstopper