check wasm-bindgen version if running with target web #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…--web isn't available Change the return type of the child run commands so it can return a CommandError that also captures the stderr if the process fails. See if the returned output contains the 'Unknown flag: --web' error message and if so provide an alternative error that suggests upgrading
…ar/wasm-pack into gameldar-627-bindgen-version-error
ashleygwilliams
force-pushed
the
gameldar-627-bindgen-version-error
branch
2 times, most recently
from
6a3e980 to
9c2ca6c
Compare
ashleygwilliams
force-pushed
the
gameldar-627-bindgen-version-error
branch
from
9c2ca6c to
b72048b
Compare
ashleygwilliams
force-pushed
the
gameldar-627-bindgen-version-error
branch
from
cf2b01a to
0a3bc9a
Compare
ashleygwilliams
force-pushed
the
gameldar-627-bindgen-version-error
branch
from
0a3bc9a to
032c9f4
Compare
ashleygwilliams
changed the title
ashleygwilliams
added
needs review
and removed
needs tests
|
CI should fail on branch but not PR on debug assertions test bug that has already been fixed on master |
|
👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#633 with merge, edits, and test