Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

i18n: Add Arabic #468

Merged
merged 6 commits into from
Mar 15, 2023
Merged

i18n: Add Arabic #468

merged 6 commits into from
Mar 15, 2023
+743 −3

Conversation

muhammadbahaa2001
Copy link
Contributor

Arabic Translation for Saber.

adil192
adil192 requested changes Mar 13, 2023
View reviewed changes
Copy link
Member

@adil192 adil192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be a few formatting errors with incorrect escape sequences scattered around the file. Please fix these and I'll take another look :)

@adil192 adil192 changed the title Create strings_ar.i18n.json i18n: Add Arabic Mar 13, 2023
adil192
adil192 requested changes Mar 14, 2023
View reviewed changes
Copy link
Member

@adil192 adil192 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please can you correct the spelling of "Sabre" to "Saber"

Edit: This was done a few times @muhammadbahaa2001

adil192
adil192 requested changes Mar 14, 2023
View reviewed changes
@muhammadbahaa2001
Copy link
Contributor Author

muhammadbahaa2001 commented Mar 14, 2023 •
edited
Loading

Also please can you correct the spelling of "Sabre" to "Saber"

Edit: This was done a few times @muhammadbahaa2001

Sorry for my mistakes (For every "Sabre" I miss it), I wish everything is corrected now.

@adil192
Copy link
Member

adil192 commented Mar 15, 2023

Sorry for my mistakes (For every "Sabre" I miss it), I wish everything is corrected now.

No worries!

adil192
adil192 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@adil192 adil192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@adil192
Copy link
Member

adil192 commented Mar 15, 2023

Would you be interested in being mentioned when there's new strings that need to be translated? #19 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023 •
edited
Loading

Codecov Report

Merging #468 (fa2dc28) into main (755c7ee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   43.38%   43.38%           
=======================================
  Files          78       78           
  Lines        5465     5465           
=======================================
  Hits         2371     2371           
  Misses       3094     3094

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adil192 adil192 merged commit cd715c8 into saber-notes:main Mar 15, 2023
adil192 pushed a commit that referenced this pull request Mar 15, 2023
@muhammadbahaa2001 @adil192
i18n: Add Arabic (#468)
814754a
@muhammadbahaa2001
Copy link
Contributor Author

Would you be interested in being mentioned when there's new strings that need to be translated? #19 (comment)

Of course, why not?

@muhammadbahaa2001
Copy link
Contributor Author

LGTM, thanks for your contribution!

You are welcome bro :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adil192 adil192 adil192 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muhammadbahaa2001 @adil192 @codecov-commenter