Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Multilingual support, Clear-all button, Theme selection #19

Closed
3 tasks done
ghost opened this issue Sep 24, 2022 · 13 comments
Closed
3 tasks done

Multilingual support, Clear-all button, Theme selection #19

ghost opened this issue Sep 24, 2022 · 13 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Sep 24, 2022

  • Multilingual Support
  • Add a button to clear or hold undo button to clear
  • Selection for theme (Auto, Light, Dark)
@adil192
Copy link
Member

adil192 commented Sep 24, 2022

Multilingual support is out-of-scope for me as I only speak one language.
The other two sound good

@ghost
Copy link
Author

ghost commented Sep 24, 2022

Multilingual support is out-of-scope for me as I only speak one language. The other two sound good

I can help for the Chinese Translation

@adil192
Copy link
Member

adil192 commented Sep 24, 2022

I can help for the Chinese Translation

I'll add multilingual support to the roadmap

adil192 added a commit that referenced this issue Sep 26, 2022
@adil192 adil192 added the enhancement New feature or request label Sep 26, 2022
adil192 added a commit that referenced this issue Sep 26, 2022
@MidNightCola
Copy link

And for theme, can we have a manual accent color? The accent color right now for me is stuck at a bad orange looking color and I can't change it, a minor inconvenience but would be appreciated

adil192 added a commit that referenced this issue Oct 9, 2022
@mamasch19
Copy link
Contributor

I can help for the Chinese Translation

I'll add multilingual support to the roadmap

I could help with a German one

@adil192
Copy link
Member

adil192 commented Oct 12, 2022

I can help for the Chinese Translation

@Sdarfeesh please can you fork this repo, copy lib/i18n/strings.i18n.json to lib/i18n/strings_zh.i18n.json and edit the English parts to Chinese

I could help with a German one

@mamasch19 that's awesome, can you do the same but for German lib/i18n/strings_de.i18n.json


Useful links:

@adil192
Copy link
Member

adil192 commented Oct 12, 2022

And for theme, can we have a manual accent color? The accent color right now for me is stuck at a bad orange looking color and I can't change it, a minor inconvenience but would be appreciated

@Triplesweet please can you make this a separate issue :)

@adil192 adil192 changed the title Some Suggestions Multilingual support, Clear-all button, Theme selection Oct 14, 2022
@ghost
Copy link
Author

ghost commented Oct 14, 2022

I can help for the Chinese Translation

@Sdarfeesh please can you fork this repo, copy lib/i18n/strings.i18n.json to lib/i18n/strings_zh.i18n.json and edit the English parts to Chinese

I could help with a German one

@mamasch19 that's awesome, can you do the same but for German lib/i18n/strings_de.i18n.json

Useful links:

These translations are missing,
could you please replace the word "Login" with "登录"?
https://github.com/adil192/saber/blob/main/lib/i18n/strings_zh.i18n.json#L40
https://github.com/adil192/saber/blob/main/lib/i18n/strings_zh.i18n.json#L56
https://github.com/adil192/saber/blob/main/lib/i18n/strings.g.dart#L423
https://github.com/adil192/saber/blob/main/lib/i18n/strings.g.dart#L555
https://github.com/adil192/saber/blob/main/lib/i18n/strings.g.dart#L689
https://github.com/adil192/saber/blob/main/lib/i18n/strings.g.dart#L706

adil192 added a commit that referenced this issue Oct 14, 2022
adil192 added a commit that referenced this issue Oct 16, 2022
@adil192
Copy link
Member

adil192 commented Oct 17, 2022

@Sdarfeesh please can I confirm with you that the Chinese translation works in-app?

@ghost
Copy link
Author

ghost commented Oct 17, 2022

@Sdarfeesh please can I confirm with you that the Chinese translation works in-app?

Works on Android

@adil192
Copy link
Member

adil192 commented Oct 17, 2022

Okay nice thanks

@adil192
Copy link
Member

adil192 commented Oct 20, 2022

Thank you to all our contributors :) I think we can consider this issue complete

@adil192 adil192 closed this as completed Oct 20, 2022
adil192 added a commit that referenced this issue Oct 22, 2022
@adil192
Copy link
Member

adil192 commented Nov 7, 2022

@Sdarfeesh @mamasch19 @iamjosuefischer @albanobattistella
Would any of you be interested in being @'ed when new entries to the English translation are added? You're under no obligation to, but please react with a thumbs up if so!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants