Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

i18n: Add Japanese #786

Merged
merged 4 commits into from
Jul 9, 2023
Merged

i18n: Add Japanese #786

merged 4 commits into from
Jul 9, 2023

Conversation

yufunagi
Copy link
Contributor

@yufunagi yufunagi commented Jul 9, 2023

Created Japanese translation of lib/i18n/strings.i18n.json.

All parts that can be translated in "strings.i18n.json" have been translated.

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #786 (95b5b00) into main (ac6a37a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #786   +/-   ##
=======================================
  Coverage   43.64%   43.64%           
=======================================
  Files          91       91           
  Lines        6399     6399           
=======================================
  Hits         2793     2793           
  Misses       3606     3606           

@adil192 adil192 changed the title Create Japanese translation of strings_ja.i18n.json i18n: Add Japanese Jul 9, 2023
@adil192 adil192 merged commit 80ce68d into saber-notes:main Jul 9, 2023
@adil192
Copy link
Member

adil192 commented Jul 9, 2023

Thank you! Would you be interested in being mentioned when there's new strings that need to be translated? #19 (comment)

@yufunagi
Copy link
Contributor Author

Thank you for accepting my pull request. Yes, please.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants