Release 1.2.0 #348

DLBPointon · 2025-01-10T11:35:19Z

Release 1.2.0

Dp24 jbrowse only

Steps into DEV not into MAIN

Dp24 module update 2

Add .ktab to output.

Dp24 module update samtools

Resources review

Dev

Dp24 new dev

Dp24 jbrowse

github-actions · 2025-01-10T11:37:20Z

`nf-core lint` overall result: Passed ✅ ⚠️

Posted for pipeline commit 715d33e

+| ✅ 127 tests passed       |+
#| ❔  20 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

nextflow_config - Config manifest.version should end in dev: '1.2.0'
pipeline_todos - TODO string in methods_description_template.yml: ## Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
system_exit - System.exit in WorkflowTreeval.groovy: System.exit(1) [line 17]

❔ Tests ignored:

files_exist - File is ignored: assets/nf-core-treeval_logo_light.png
files_exist - File is ignored: conf/test_full.config
files_exist - File is ignored: docs/images/nf-core-treeval_logo_light.png
files_exist - File is ignored: docs/images/nf-core-treeval_logo_dark.png
files_exist - File is ignored: conf/igenomes.config
files_exist - File is ignored: .github/workflows/awstest.yml
files_exist - File is ignored: .github/workflows/awsfulltest.yml
nextflow_config - Config variable ignored: manifest.name
nextflow_config - Config variable ignored: manifest.homePage
files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
files_unchanged - File does not exist: assets/nf-core-treeval_logo_light.png
files_unchanged - File does not exist: docs/images/nf-core-treeval_logo_light.png
files_unchanged - File does not exist: docs/images/nf-core-treeval_logo_dark.png
files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/treeval/treeval/.github/workflows/awstest.yml

✅ Tests passed:

files_exist - File found: .gitattributes
files_exist - File found: .gitignore
files_exist - File found: .nf-core.yml
files_exist - File found: .editorconfig
files_exist - File found: .prettierignore
files_exist - File found: .prettierrc.yml
files_exist - File found: CHANGELOG.md
files_exist - File found: CITATIONS.md
files_exist - File found: CODE_OF_CONDUCT.md
files_exist - File found: CODE_OF_CONDUCT.md
files_exist - File found: LICENSE or LICENSE.md or LICENCE or LICENCE.md
files_exist - File found: nextflow_schema.json
files_exist - File found: nextflow.config
files_exist - File found: README.md
files_exist - File found: .github/.dockstore.yml
files_exist - File found: .github/CONTRIBUTING.md
files_exist - File found: .github/ISSUE_TEMPLATE/bug_report.yml
files_exist - File found: .github/ISSUE_TEMPLATE/config.yml
files_exist - File found: .github/ISSUE_TEMPLATE/feature_request.yml
files_exist - File found: .github/PULL_REQUEST_TEMPLATE.md
files_exist - File found: .github/workflows/branch.yml
files_exist - File found: .github/workflows/ci.yml
files_exist - File found: .github/workflows/linting_comment.yml
files_exist - File found: .github/workflows/linting.yml
files_exist - File found: assets/email_template.html
files_exist - File found: assets/email_template.txt
files_exist - File found: assets/sendmail_template.txt
files_exist - File found: conf/modules.config
files_exist - File found: conf/test.config
files_exist - File found: docs/output.md
files_exist - File found: docs/README.md
files_exist - File found: docs/README.md
files_exist - File found: docs/usage.md
files_exist - File found: lib/nfcore_external_java_deps.jar
files_exist - File found: lib/NfcoreSchema.groovy
files_exist - File found: lib/NfcoreTemplate.groovy
files_exist - File found: lib/Utils.groovy
files_exist - File found: lib/WorkflowMain.groovy
files_exist - File found: main.nf
files_exist - File found: assets/multiqc_config.yml
files_exist - File found: conf/base.config
files_exist - File found: lib/WorkflowTreeval.groovy
files_exist - File found: modules.json
files_exist - File found: pyproject.toml
files_exist - File not found check: Singularity
files_exist - File not found check: parameters.settings.json
files_exist - File not found check: .nf-core.yaml
files_exist - File not found check: bin/markdown_to_html.r
files_exist - File not found check: conf/aws.config
files_exist - File not found check: .github/workflows/push_dockerhub.yml
files_exist - File not found check: .github/ISSUE_TEMPLATE/bug_report.md
files_exist - File not found check: .github/ISSUE_TEMPLATE/feature_request.md
files_exist - File not found check: docs/images/nf-core-treeval_logo.png
files_exist - File not found check: .markdownlint.yml
files_exist - File not found check: .yamllint.yml
files_exist - File not found check: lib/Checks.groovy
files_exist - File not found check: lib/Completion.groovy
files_exist - File not found check: lib/Workflow.groovy
files_exist - File not found check: .travis.yml
nextflow_config - Config variable found: manifest.nextflowVersion
nextflow_config - Config variable found: manifest.description
nextflow_config - Config variable found: manifest.version
nextflow_config - Config variable found: timeline.enabled
nextflow_config - Config variable found: trace.enabled
nextflow_config - Config variable found: report.enabled
nextflow_config - Config variable found: dag.enabled
nextflow_config - Config variable found: process.cpus
nextflow_config - Config variable found: process.memory
nextflow_config - Config variable found: process.time
nextflow_config - Config variable found: params.outdir
nextflow_config - Config variable found: params.input
nextflow_config - Config variable found: params.show_hidden_params
nextflow_config - Config variable found: params.schema_ignore_params
nextflow_config - Config variable found: manifest.mainScript
nextflow_config - Config variable found: timeline.file
nextflow_config - Config variable found: trace.file
nextflow_config - Config variable found: report.file
nextflow_config - Config variable found: dag.file
nextflow_config - Config variable (correctly) not found: params.nf_required_version
nextflow_config - Config variable (correctly) not found: params.container
nextflow_config - Config variable (correctly) not found: params.singleEnd
nextflow_config - Config variable (correctly) not found: params.igenomesIgnore
nextflow_config - Config variable (correctly) not found: params.name
nextflow_config - Config variable (correctly) not found: params.enable_conda
nextflow_config - Config timeline.enabled had correct value: true
nextflow_config - Config report.enabled had correct value: true
nextflow_config - Config trace.enabled had correct value: true
nextflow_config - Config dag.enabled had correct value: true
nextflow_config - Config dag.file ended with .html
nextflow_config - Config variable manifest.nextflowVersion started with >= or !>=
nextflow_config - Config params.custom_config_version is set to master
nextflow_config - Config params.custom_config_base is set to https://raw.githubusercontent.com/nf-core/configs/master
nextflow_config - Lines for loading custom profiles found
files_unchanged - .gitattributes matches the template
files_unchanged - .prettierrc.yml matches the template
files_unchanged - .github/.dockstore.yml matches the template
files_unchanged - .github/ISSUE_TEMPLATE/feature_request.yml matches the template
files_unchanged - .github/PULL_REQUEST_TEMPLATE.md matches the template
files_unchanged - .github/workflows/branch.yml matches the template
files_unchanged - .github/workflows/linting_comment.yml matches the template
files_unchanged - assets/email_template.html matches the template
files_unchanged - assets/email_template.txt matches the template
files_unchanged - docs/README.md matches the template
files_unchanged - lib/nfcore_external_java_deps.jar matches the template
files_unchanged - lib/NfcoreSchema.groovy matches the template
actions_ci - '.github/workflows/ci.yml' is triggered on expected events
actions_ci - '.github/workflows/ci.yml' checks minimum NF version
readme - README Nextflow minimum version badge matched config. Badge: 22.10.1, Config: 22.10.1
readme - README Zenodo placeholder was replaced with DOI.
pipeline_name_conventions - Name adheres to nf-core convention
template_strings - Did not find any Jinja template strings (436 files)
schema_lint - Schema lint passed
schema_lint - Schema title + description lint passed
schema_lint - Input mimetype lint passed: 'text/yaml'
schema_params - Schema matched params returned from nextflow config
actions_schema_validation - Workflow validation passed: linting_comment.yml
actions_schema_validation - Workflow validation passed: clean-up.yml
actions_schema_validation - Workflow validation passed: linting.yml
actions_schema_validation - Workflow validation passed: sanger_test_full.yml
actions_schema_validation - Workflow validation passed: fix-linting.yml
actions_schema_validation - Workflow validation passed: branch.yml
actions_schema_validation - Workflow validation passed: ci.yml
merge_markers - No merge markers found in pipeline files
modules_json - Only installed modules found in modules.json
multiqc_config - 'assets/multiqc_config.yml' follows the ordering scheme of the minimally required plugins.
multiqc_config - 'assets/multiqc_config.yml' contains 'export_plots: true'.
modules_structure - modules directory structure is correct 'modules/nf-core/TOOL/SUBTOOL'

Run details

nf-core/tools version 2.8
Run at 2025-01-13 11:20:42

CHANGELOG.md

Adding comments from Will

DLBPointon and others added 30 commits November 15, 2024 11:46

Merge branch 'main' into dev

43b4cf0

Merge pull request #307 from sanger-tol/dp24_jbrowse_only

f7d9db2

Dp24 jbrowse only

Updates for modules, README and config

cb5d998

Add ktab to output

8aad21a

Update documentation

ca2afc4

Merge pull request #330 from sanger-tol/dp24_steps

52f5bf9

Steps into DEV not into MAIN

Updating SAMTOOLS

79bd32f

linting

217bd32

Updating all easy to update modules

30a576c

Updating all easy to update modules

e93fd9a

Updating all easy to update modules

dc1e076

Updating all easy to update modules

3c660bb

Fixes to modules

32152a5

linting

1beeeb5

Patches

ae7380c

Merge branch 'dev' of https://github.com/sanger-tol/treeval into dev

27439f5

Adding steps to skip BUSCO

4ad0c65

Pinning BUSCO to V5.5

160af01

Removing steps var

55ed6d6

Linting

0ada598

Merge pull request #335 from sanger-tol/dp24_module_update_2

85217d9

Dp24 module update 2

Merge pull request #327 from sanger-tol/tola399_outputktab

701b19b

Add .ktab to output.

Minor updates

9268b77

Resources review

8356733

Merge pull request #333 from sanger-tol/dp24_module_update_samtools

7a0ca25

Dp24 module update samtools

Merge pull request #336 from sanger-tol/tola401_updateresources

b9600d9

Resources review

add binfile output and update pretext_graph

0ecff8d

add binfile output and update pretext_graph

26a41a8

Updating last of NF-core modules

cc96248

Merge pull request #338 from sanger-tol/dev

107582a

Dev

DLBPointon and others added 18 commits December 10, 2024 13:46

BigDecimal is now overloading?

44200e5

hic_report is missing

934e9e0

hic_report change

c877ca2

Updates to container

8198e89

Adding default for steps in config

8a24f14

All should have been None

0dcc269

Update ci.yml

1109a05

Testing so we can see priv levels

17996bb

Testing so we can see priv levels - correct order

d5b7a1e

Testing so we can see priv levels

e611af4

Testing so we can see priv levels

19689c9

Testing so we can see priv levels

9422849

Testing so we can see priv levels

c98db8d

Merge pull request #346 from sanger-tol/dp24_new_dev

f551ab8

Dp24 new dev

Readding JBROWSE run

a52dc51

Remove FKprof again

686f7d0

Declare JBROWSE correctly in main.nf

7f22372

Merge pull request #347 from sanger-tol/dp24_jbrowse

be7155e

Dp24 jbrowse

DLBPointon requested a review from weaglesBio January 10, 2025 11:35

DLBPointon self-assigned this Jan 10, 2025

DLBPointon changed the title ~~Rlease 1.2.0~~ Release 1.2.0 Jan 10, 2025

weaglesBio requested changes Jan 10, 2025

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

DLBPointon and others added 2 commits January 13, 2025 09:27

Adding comments from Will

55ffa2b

Merge pull request #349 from sanger-tol/dp24_jbrowse

715d33e

Adding comments from Will

DLBPointon requested a review from weaglesBio January 13, 2025 11:45

weaglesBio approved these changes Jan 13, 2025

View reviewed changes

DLBPointon requested a review from yumisims January 13, 2025 14:59

yumisims approved these changes Jan 13, 2025

View reviewed changes

DLBPointon merged commit 577d30b into main Jan 14, 2025
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.2.0 #348

Release 1.2.0 #348

DLBPointon commented Jan 10, 2025

github-actions bot commented Jan 10, 2025 •

edited

Loading

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

Release 1.2.0 #348

Release 1.2.0 #348

Conversation

DLBPointon commented Jan 10, 2025

github-actions bot commented Jan 10, 2025 • edited Loading

nf-core lint overall result: Passed ✅ ⚠️

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

github-actions bot commented Jan 10, 2025 •

edited

Loading

`nf-core lint` overall result: Passed ✅ ⚠️