Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Second round fixes #51

Merged
merged 54 commits into from
Jan 19, 2023
Merged

Second round fixes #51

merged 54 commits into from
Jan 19, 2023

Conversation

DLBPointon
Copy link
Contributor

Pipeline runs and completes, this PR affects Issues #36, #37, #38, #39, #40, #41, #42, #46, #47.

There have been additional changes to yaml_input due to an issue that stopped some top-level YAML values from being read by the function.

@DLBPointon DLBPointon added enhancement New feature or request Planned Additions A planned addition to the initial project labels Jan 10, 2023
@DLBPointon DLBPointon self-assigned this Jan 10, 2023
Copy link
Contributor Author

DLBPointon commented Jan 10, 2023

modules.json was generated in nf_core-2.7, unsure whether this is what is causing the prettier fail.

nf-core lint will also not run locally on farm due to quota issues that don't seem to actually exist.

@muffato
Copy link
Member

muffato commented Jan 19, 2023

Merging this as the tests pass locally. An issue will be created for getting the pipeline to work outside of Sanger systems, incl. on GitHub

@muffato muffato merged commit 129dea2 into dev Jan 19, 2023
@muffato muffato deleted the second-round-fixes branch January 19, 2023 15:47
@muffato muffato mentioned this pull request Jan 20, 2023
DLBPointon added a commit that referenced this pull request Sep 7, 2023
DLBPointon pushed a commit that referenced this pull request Sep 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request Planned Additions A planned addition to the initial project
Projects
None yet
2 participants