-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Including a @mixin
when outside of selector still outputs properties
#1732
Comments
xzyfer
added a commit
to xzyfer/sass-spec
that referenced
this issue
Nov 13, 2015
This PR add specs for sass/libsass#1732
Thanks for the report @ezekg. |
Spec added sass/sass-spec#613 |
This is a bit more complicated since the check cannot be done in parser, since the following is valid: @mixin a {
b: c;
}
foo {
@include a();
} So we need to do this check after the mixin is expanded. |
WIP to fix this in #1900 |
Reassiging this to 3.4. This doesn't prevent people to from migrating to LibSass I suspect browsers will simply ignore these erroneous properties. |
xzyfer
added a commit
to xzyfer/libsass
that referenced
this issue
May 1, 2016
This is introduces a vastly reduced `CheckNesting` visitor from Ruby Sass as discussed in sass#2061. Doing this properly will require some small changes to the parser, and probably eval, which currently try to do some nesting checking of their own. This is just first step to properly introducing the proper nesting checking. Closes sass#2061 Fixes sass#1732
xzyfer
added a commit
to xzyfer/libsass
that referenced
this issue
May 1, 2016
This is introduces a vastly reduced `CheckNesting` visitor from Ruby Sass as discussed in sass#2061. Doing this properly will require some small changes to the parser, and probably eval, which currently try to do some nesting checking of their own. This is just first step to properly introducing the proper nesting checking. Closes sass#2061 Fixes sass#1732
xzyfer
added a commit
to xzyfer/libsass
that referenced
this issue
May 1, 2016
This is introduces a vastly reduced `CheckNesting` visitor from Ruby Sass as discussed in sass#2061. Doing this properly will require some small changes to the parser, and probably eval, which currently try to do some nesting checking of their own. This is just first step to properly introducing the proper nesting checking. Closes sass#2061 Fixes sass#1732
xzyfer
added a commit
to xzyfer/sass-spec
that referenced
this issue
May 2, 2016
This PR activates specs for sass/libsass#1732
xzyfer
added a commit
to xzyfer/libsass
that referenced
this issue
May 2, 2016
This is introduces a vastly reduced `CheckNesting` visitor from Ruby Sass as discussed in sass#2061. Doing this properly will require some small changes to the parser, and probably eval, which currently try to do some nesting checking of their own. This is just first step to properly introducing the proper nesting checking. Closes sass#2061 Fixes sass#1732
xzyfer
added a commit
to xzyfer/libsass
that referenced
this issue
May 2, 2016
This is introduces a vastly reduced `CheckNesting` visitor from Ruby Sass as discussed in sass#2061. Doing this properly will require some small changes to the parser, and probably eval, which currently try to do some nesting checking of their own. This is just first step to properly introducing the proper nesting checking. Closes sass#2061 Fixes sass#1732
xzyfer
added a commit
to xzyfer/libsass
that referenced
this issue
May 2, 2016
This is introduces a vastly reduced `CheckNesting` visitor from Ruby Sass as discussed in sass#2061. Doing this properly will require some small changes to the parser, and probably eval, which currently try to do some nesting checking of their own. This is just first step to properly introducing the proper nesting checking. Closes sass#2061 Fixes sass#1732
xzyfer
added a commit
to xzyfer/sass-spec
that referenced
this issue
May 2, 2016
This PR activates specs for sass/libsass#1732
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
As mentioned in ezekg/flint#40 (comment) and similar to #1585.
Reproducable test case:
Compiling with Ruby Sass results in:
Cmd:
sass test.scss
Compiling with Libsass results in:
Cmd:
sassc test.scss
The text was updated successfully, but these errors were encountered: