Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add SassC to the CI build setup #904

Closed
wants to merge 1 commit into from
Closed

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Sep 3, 2016

Uses the same build logic as the SassC CI setup, and adds an extra
build to the Travis matrix. Currently the Sass Language for SassC is
pinned to 3.4 to match libsass testing.

Uses the same build logic as the SassC CI setup, and adds an extra
build to the Travis matrix. Currently the Sass Language for SassC is
pinned to 3.4 to match libsass testing.
@xzyfer
Copy link
Contributor

xzyfer commented Sep 4, 2016

This is going to an issue to LibSass development. If I understand correctly this PR would cause sass-spec to fail PRs for activating specs that aren't on LibSass master yet.

The LibSass development workflow is to create a sass-spec PR that activates a spec the LibSass PR is intending to fix. The LibSass CI will check out that sass-spec PR and test against that branch instead of master. This asserts that the LibSass PR does indeed fix the what it's intending too.

Example sass/libsass#2062 was intended to fix sass/libsass#1732. To assert it did that we created #857 which activates the relevant spec. This means that the LibSass PR will not pass CI if that spec (or any other active spec) fails.

@nschonni
Copy link
Contributor Author

nschonni commented Sep 4, 2016

Sorry, I had added the SassC stuff to allowed failures, but I must of removed it before the final push

@nschonni
Copy link
Contributor Author

nschonni commented Sep 4, 2016

I'll reopen this in a minute, just closing while a fixup and test with travis on my own Travis setup

@nschonni nschonni closed this Sep 4, 2016
@nschonni
Copy link
Contributor Author

nschonni commented Sep 4, 2016

OK, extended the test matrix to include 3.4, 3.5, and 4.0 with SassC, but added all of them to the allowed failures in the matrix. Also moved the ci build stuff to a separate script, so the other one can continue to be used by the devs

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants