Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update list equality to take is_bracketed into account #2281

Merged
merged 1 commit into from
Jan 5, 2017
Merged

Update list equality to take is_bracketed into account #2281

merged 1 commit into from
Jan 5, 2017

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Jan 2, 2017 •
edited
Loading

Bracketed lists introduce an is_bracketed attribute to lists.
Whether a list is bracketed needs be taken into account when
determining equality.

See sass/sass#2121
Fixes #2280
Spec sass/sass-spec#896

@xzyfer xzyfer added this to the 3.5.0.beta.1 milestone Jan 2, 2017
@xzyfer xzyfer self-assigned this Jan 2, 2017
xzyfer added a commit to xzyfer/libsass that referenced this pull request Jan 2, 2017
@xzyfer
Add list delimiter support to the C API
bb3da21 
Lists gained a delimiter attribute in sass#2279. The primary semantic
difference is that the delimiter changes list equality (sass#2281) which
can matter in custom functions.

This is a breaking change so I'd like to get it into the first 3.5
beta.
@xzyfer xzyfer mentioned this pull request Jan 2, 2017
Merged
xzyfer added a commit to xzyfer/libsass that referenced this pull request Jan 5, 2017
@xzyfer
Add list delimiter support to the C API
ab00600 
Lists gained a delimiter attribute in sass#2279. The primary semantic
difference is that the delimiter changes list equality (sass#2281) which
can matter in custom functions.

This is a breaking change so I'd like to get it into the first 3.5
beta.
xzyfer added a commit to xzyfer/libsass that referenced this pull request Jan 5, 2017
@xzyfer
Add list delimiter support to the C API
9450d37 
Lists gained an `is_bracketed` attribute in sass#2279. The primary
semantic difference is that the`is_bracketed` changes list equality
(sass#2281) which can matter in custom functions.

This is a breaking change so I'd like to get it into the first 3.5
beta.
xzyfer added a commit to xzyfer/libsass that referenced this pull request Jan 5, 2017
@xzyfer
Add list delimiter support to the C API
c2739e3 
Lists gained an `is_bracketed` attribute in sass#2284. The primary
semantic difference is that the`is_bracketed` changes list equality
(sass#2281) which can matter in custom functions.

This is a breaking change so I'd like to get it into the first 3.5
beta.
@xzyfer xzyfer changed the title Update list equality to take delimiters into account Update list equality to take is_bracketed into account Jan 5, 2017
@xzyfer
Update list equality to take delimiters into account
641e6cf 
Bracketed lists introduce an `is_bracketed` attribute to lists.
Whether a list is bracketed needs be taken into account when
determining equality.

See sass/sass#2121
Fixes sass#2280
Spec sass/sass-spec#896
@xzyfer xzyfer merged commit 7abaa75 into sass:master Jan 5, 2017
@xzyfer xzyfer deleted the list-equality branch January 5, 2017 10:17
xzyfer added a commit that referenced this pull request Mar 5, 2017
@xzyfer
Revert "Merge pull request #2281 from xzyfer/list-equality"
51ea6ed 
This reverts commit 7abaa75, reversing
changes made to 6537833.
mgreter pushed a commit that referenced this pull request Apr 8, 2017
@xzyfer @mgreter
Revert "Merge pull request #2281 from xzyfer/list-equality"
8a68679 
This reverts commit 7abaa75, reversing
changes made to 6537833.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@xzyfer xzyfer

Labels
Dev - PR Ready Dev - Test Written Sass 3.5
Projects
None yet
Milestone
3.5.0.beta.1
Development

Successfully merging this pull request may close these issues.
1 participant
@xzyfer