Remove Sass_List_Delimiter in favour of an is_bracketed property #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
force-pushed
the
remove-list-delimiter
branch
2 times, most recently
from
7b607fb to
bf095ff
Compare
xzyfer
force-pushed
the
remove-list-delimiter
branch
from
bf095ff to
83ec7e7
Compare
The list delimiter property only existed as a way to preserve parser state on the node in order to reused the existing `parse_list` function. This PR instead adds a `parse_bracketed_list` function to explicitly parse bracketed lists and sets the `is_bracketed` property on the `List` node. It turns out this is exactly what Ruby Sass does.
xzyfer
force-pushed
the
remove-list-delimiter
branch
from
83ec7e7 to
e2efacd
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list delimiter property only existed as a way to preserve parser
state on the node in order to reused the existing
parse_listfunction.This PR instead adds a
parse_bracketed_listfunction to explicitlyparse bracketed lists and sets the
is_bracketedproperty on theListnode. It turns out this is exactly what Ruby Sass does.