Remove ServiceWorkerContainer.onerror #380
Conversation
|
@unarist apologies that we are just getting to this, thank you for your contribution!! Have there been any relevant updates to the spec since your PR? |
The spec seems to not changed about this. MDN docs had been updated to deprecate ServiceWorkerContainer.onerror. For |
|
@unarist thanks for getting back on this! |
|
Ok @unarist & @armanbilge , in order to preserve backwards-binary-compatibility, I've restored the field but marked it as deprecated. We'll remove all the deprecated stuff on the 2.x branch (or not) |
|
Wait, why is this binary incompatible? |
|
This is a facade so it falls under the exceptions: #461 (comment) |
|
ARGH! Thanks @armanbilge , I forgot this case is an SJS bincomat exception. D'oh. I'll revert... |
|
I wonder if we could use your scalafix to generate list of MiMa exceptions, so we can just run MiMa. One day! |
|
Actually yeah, that's a really good idea. I should be able to implement that reasonably quickly. I'll see if I can smash it out today... |
|
@japgolly You rock!! Your scalafix wizardry has already opened my eyes 🤩 Plus I think this could be super-helpful for a future auto-generation scheme. |
|
Boom. Merged. Thanks for the PR (and your incredible patience) @unarist , and thanks for you attentive reviewing. :) |
|
That was our last PR! How do you feel about cutting a release @japgolly? The remaining issues look like infrastructure/internal stuff mostly: https://github.com/scala-js/scala-js-dom/milestone/1 |
It looks like not documented in the spec nor implemented in browsers.
see w3c/ServiceWorker#912
The current spec has
messageerrorevent instead, but I'm omitting it because it is not described at MDN nor implemented Chrome for now. Tell me if I should include it in this PR.