Skip to content

Remove ServiceWorkerContainer.onerror #380

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Aug 25, 2021
Merged

Remove ServiceWorkerContainer.onerror #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
050eab9
Remove ServiceWorkerContainer.onerror
unarist Sep 9, 2019
22de61f
Merge remote-tracking branch 'upstream/series/1.x' into sw-onerror
armanbilge Aug 24, 2021
1626604
prePR
armanbilge Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,7 +1028,6 @@ experimental/serviceworkers/ServiceWorkerContainer[ST] def controller: ServiceWo
experimental/serviceworkers/ServiceWorkerContainer[ST] def getRegistration(scope: String = ""): js.Promise[js.UndefOr[ServiceWorkerRegistration]]
experimental/serviceworkers/ServiceWorkerContainer[ST] def getRegistrations(): js.Promise[js.Array[ServiceWorkerRegistration]]
experimental/serviceworkers/ServiceWorkerContainer[ST] var oncontrollerchange: js.Function1[Event, _]
experimental/serviceworkers/ServiceWorkerContainer[ST] var onerror: js.Function1[ErrorEvent, _]
experimental/serviceworkers/ServiceWorkerContainer[ST] var onmessage: js.Function1[MessageEvent, _]
experimental/serviceworkers/ServiceWorkerContainer[ST] def ready: js.Promise[ServiceWorkerRegistration]
experimental/serviceworkers/ServiceWorkerContainer[ST] def register(scriptURL: String, options: js.Object = new js.Object()): js.Promise[ServiceWorkerRegistration]
Expand Down
1 change: 0 additions & 1 deletion api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,7 +1028,6 @@ experimental/serviceworkers/ServiceWorkerContainer[ST] def controller: ServiceWo
experimental/serviceworkers/ServiceWorkerContainer[ST] def getRegistration(scope: String = ""): js.Promise[js.UndefOr[ServiceWorkerRegistration]]
experimental/serviceworkers/ServiceWorkerContainer[ST] def getRegistrations(): js.Promise[js.Array[ServiceWorkerRegistration]]
experimental/serviceworkers/ServiceWorkerContainer[ST] var oncontrollerchange: js.Function1[Event, _]
experimental/serviceworkers/ServiceWorkerContainer[ST] var onerror: js.Function1[ErrorEvent, _]
experimental/serviceworkers/ServiceWorkerContainer[ST] var onmessage: js.Function1[MessageEvent, _]
experimental/serviceworkers/ServiceWorkerContainer[ST] def ready: js.Promise[ServiceWorkerRegistration]
experimental/serviceworkers/ServiceWorkerContainer[ST] def register(scriptURL: String, options: js.Object = new js.Object()): js.Promise[ServiceWorkerRegistration]
Expand Down
9 changes: 0 additions & 9 deletions src/main/scala/org/scalajs/dom/experimental/serviceworkers/ServiceWorkers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,15 +381,6 @@ trait ServiceWorkerContainer extends EventTarget {
*/
var oncontrollerchange: js.Function1[Event, _] = js.native

/**
* The onerror property of the ServiceWorkerContainer interface is an event
* handler fired whenever an error event occurs in the associated service
* workers.
*
* MDN
*/
var onerror: js.Function1[ErrorEvent, _] = js.native

/**
* The onmessage property of the ServiceWorkerContainer interface is an event
* handler fired whenever a message event occurs — when incoming messages are
Expand Down